Return-path: Received: from wolverine01.qualcomm.com ([199.106.114.254]:46565 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751683Ab2AMLy2 (ORCPT ); Fri, 13 Jan 2012 06:54:28 -0500 Message-ID: <4F101B6D.2020405@qca.qualcomm.com> (sfid-20120113_125431_822970_BD00C388) Date: Fri, 13 Jan 2012 13:54:21 +0200 From: Kalle Valo MIME-Version: 1.0 To: CC: , ath6kl-devel Subject: Re: [PATCH 1/2] ath6kl: Remove useless initialization in ath6kl_read_fwlogs() References: <1326360708-9362-1-git-send-email-rmani@qca.qualcomm.com> In-Reply-To: <1326360708-9362-1-git-send-email-rmani@qca.qualcomm.com> Content-Type: text/plain; charset="ISO-8859-1" Sender: linux-wireless-owner@vger.kernel.org List-ID: On 01/12/2012 11:31 AM, rmani@qca.qualcomm.com wrote: > From: Raja Mani > > ath6kl_read_fwlogs() assigns the value zero to the variable 'ret' > at the time of declaration. Later, return value of ath6kl_diag_read32() > repalces the init value. Hence removing useless zero assignment. > > Signed-off-by: Raja Mani Thanks, applied. BTW, I only got patch 1/2. What happened to patch 2? Kalle