Return-path: Received: from mail-iy0-f174.google.com ([209.85.210.174]:52840 "EHLO mail-iy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752541Ab2A3NwH (ORCPT ); Mon, 30 Jan 2012 08:52:07 -0500 Received: by iacb35 with SMTP id b35so5200190iac.19 for ; Mon, 30 Jan 2012 05:52:06 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <87fwexco94.fsf@purkki.adurom.net> References: <1327924857-1250-1-git-send-email-eliad@wizery.com> <87fwexco94.fsf@purkki.adurom.net> Date: Mon, 30 Jan 2012 15:52:06 +0200 Message-ID: (sfid-20120130_145219_517648_0B0FF2EB) Subject: Re: [PATCH 00/12] wl12xx: update fw api From: Eliad Peller To: Kalle Valo Cc: Luciano Coelho , linux-wireless@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, Jan 30, 2012 at 3:29 PM, Kalle Valo wrote: > Eliad Peller writes: > >> The fw api was changed in the latest FWs (6.3.5.0.95 for wl127x >> and 7.3.5.0.95 for wl128x). >> >> Along with some small adjustments, the main changes >> inroduced by this patheset are configuring the >> templates per-role, and moving to IEEE80211_HW_SUPPORTS_DYNAMIC_PS >> mode. > > I didn't look so carefully, but doesn't this break bisect? I mean if you > change the firmware api in small patches wl12xx can't work properly > until all patches are applied, right? > > I would say that a huge patch doing all the necessary changes in one go > is better, even it's ugly. > yes. it will break bisect (although it shouldn't break compilations). i guess it's a matter of taste, but i think keeping the patches manageable is more important than being able to bisect. Eliad.