Message-ID: <4F048F26.5000804@lwfinger.net> (sfid-20120104_184124_840672_F8E006AE)
Date: Wed, 04 Jan 2012 11:40:54 -0600
From: Larry Finger <Larry.Finger@lwfinger.net>
MIME-Version: 1.0
To: "John W. Linville" <linville@tuxdriver.com>
CC: davem@davemloft.net, linux-wireless@vger.kernel.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: pull request: wireless 2012-01-04
References: <20120104155816.GE2540@tuxdriver.com> <20120104163109.GF2540@tuxdriver.com>
In-Reply-To: <20120104163109.GF2540@tuxdriver.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Sender: linux-wireless-owner@vger.kernel.org

On 01/04/2012 10:31 AM, John W. Linville wrote:
> On Wed, Jan 04, 2012 at 10:58:16AM -0500, John W. Linville wrote:
>
>> I was hesitant to include the rtlwifi fix, but settled on inclusion
>> because it was a product of a recent ginormous thread about the
>> intersection of firmware loading and suspend/resume.  Plus it fixes
>> a bug report in the Red Hat Bugzilla. :-) If you don't think it is
>> worthy, let me know and I'll drop it from this release.
>
> It looks like this could generate a build warning...
>
> 	http://marc.info/?l=linux-wireless&m=132569396407866&w=2
>
> I'm getting cold feet on this one.  I withdraw this pull request --
> new one to follow soon!

John,

I will resubmit this patch with a fix.

I now realize that my fix has a different problem in that the firmware might not 
be preserved under certain scenarios if there were two instances of the device 
sharing the driver. These are corner cases, but I would like to fix that as well.

Is there any way for a driver to know that it is being initialized for a second 
device?

Thanks,

Larry