Return-path: Received: from mail-iy0-f174.google.com ([209.85.210.174]:42189 "EHLO mail-iy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750824Ab2AWSpx (ORCPT ); Mon, 23 Jan 2012 13:45:53 -0500 Received: by iacb35 with SMTP id b35so4097465iac.19 for ; Mon, 23 Jan 2012 10:45:53 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: <1327338154-3806-1-git-send-email-eliad@wizery.com> Date: Mon, 23 Jan 2012 20:45:53 +0200 Message-ID: (sfid-20120123_194557_004148_F3D943F2) Subject: Re: [PATCH] compat-wireless: fix wl12xx driver-select From: Eliad Peller To: "Luis R. Rodriguez" Cc: linux-wireless@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, Jan 23, 2012 at 8:28 PM, Luis R. Rodriguez wrote: > On Mon, Jan 23, 2012 at 10:09 AM, Eliad Peller wrote: >> On Mon, Jan 23, 2012 at 7:23 PM, Luis R. Rodriguez wrote: >>> On Mon, Jan 23, 2012 at 9:02 AM, Eliad Peller wrote: >>>> wl12xx is a possible choice for both group drivers and >>>> singular modules (making it impossible to build only >>>> the wl12xx module). change the group name to "ti" instead. >>>> >>>> Signed-off-by: Eliad Peller >>>> --- >>> >>> Is this a stable fix for linux-3.3.y branch of compat-wireless or only >>> for the master branch ? >>> >> this is a stable fix (not very important one, though. only avoids some >> redundant compilations). > > I just see this doing name changes for driver-select, how is this > fixing anything? > because the "switch" has 2 "cases" with the same value. currently, "driver-select wl12xx" selects both wl12xx and wl1251 (because the first wl12xx "case" is chosen) you can't select only wl12xx. after this fix: driver-select ti - selects wl12xx and wl1251 driver-select wl12xx - selects only wl12xx Eliad.