Return-path: Received: from mail-wi0-f174.google.com ([209.85.212.174]:45112 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752606Ab2ABV10 (ORCPT ); Mon, 2 Jan 2012 16:27:26 -0500 MIME-Version: 1.0 In-Reply-To: <20120102211904.GA15316@srcf.ucam.org> References: <4F02165C.1060400@fastmail.fm> <20120102211904.GA15316@srcf.ucam.org> From: Linus Torvalds Date: Mon, 2 Jan 2012 13:27:03 -0800 Message-ID: (sfid-20120102_222742_094947_9520821B) Subject: Re: loading firmware while usermodehelper disabled. To: Matthew Garrett Cc: Jack Stone , Alan Stern , Oliver Neukum , Dave Jones , Linux Kernel , Larry Finger , Chaoming Li , "John W. Linville" , Greg Kroah-Hartman , USB list , Linux Wireless List Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, Jan 2, 2012 at 1:19 PM, Matthew Garrett wrote: > On Mon, Jan 02, 2012 at 12:48:48PM -0800, Linus Torvalds wrote: > >> Why are you guys making it any more complicated than that? > > Because it's inadequate. You can't guarantee that we ever loaded > firmware. If we didn't load the firmware before the suspend, then the resume function of a device sure as hell had better not load it at resume time either. And don't make the stupid argument that we don't know. That's just inane. Either the driver loads the firmware at startup, or it doesn't. If it loads it at startup, the firmware will have been loaded. If it loads it only at "open" time or similar (and the device wasn't opened), then the resume had better *know* about that, and not try to load the firmware of a device that wasn't open! And for chrissake, don't bother making it more complicated than it is, just for some theoretical hardware or situation that nobody cares about. Go back to the original report of the *actual* problems we have. They are not some complex case where things magically change. The REAL ACTUAL problems that people have are for very straightforward situations where we simply do the wrong thing, largely because our firmware loading is full of crap. Fix the 99%. Screw the crazy shit, don't even bother worrying about it until *after* the 99% is fixed. Linus