Return-path: Received: from mail-bk0-f46.google.com ([209.85.214.46]:53637 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753185Ab2BWSIa (ORCPT ); Thu, 23 Feb 2012 13:08:30 -0500 Received: by bkcjm19 with SMTP id jm19so1324508bkc.19 for ; Thu, 23 Feb 2012 10:08:29 -0800 (PST) From: Christian Lamparter To: Nicolas Cavallari Subject: Re: [RFC] carl9170: Fix memory accounting when sta is in power-save mode. Date: Thu, 23 Feb 2012 19:08:16 +0100 Cc: "John W. Linville" , linux-wireless@vger.kernel.org References: <1330012414-26559-1-git-send-email-cavallar@lri.fr> <201202231752.44125.chunkeey@googlemail.com> <4F46771F.9000200@lri.fr> In-Reply-To: <4F46771F.9000200@lri.fr> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Message-Id: <201202231908.16364.chunkeey@googlemail.com> (sfid-20120223_190834_078914_5140872A) Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thursday, February 23, 2012 06:27:59 PM Nicolas Cavallari wrote: > On 23/02/2012 17:52, Christian Lamparter wrote: > > On Thursday, February 23, 2012 04:53:34 PM Nicolas Cavallari wrote: > >> While this seems to fix my problem, there could still be problems remaining > >> in this code path. Particularly carl9170_tx_status will do lots of things > >> like incrementing counters and waking up mac80211 queues... > > That should be alright. As a rule of thumb, for every call to > > carl9170_tx_accounting [called by carl9170_op_tx tx handler] > > we need to call carl9170_tx_status. If the station is still in > > ps mode, mac80211 will cache the station's frames and sets > > the TIM bits. > > Part of the reason i wrote this, is because, while this patch fixes the > memory accounting problem and prevent the AP from stopping working, the > powersaving station sometimes cannot communicate with the AP anymore > (other stations can). The station uses ath9k, and is just really doing a > background scan. The first traces that i have just indicate that the > station entered powersave mode, then sends probe requests and probe > requests directed to the AP, then sends authentication requests to the > AP (?), but the AP does not respond to any of them... > Do you run an 802.11n ap on carl9170? Regards, Chr