Return-path: Received: from smtp1.u-psud.fr ([129.175.33.41]:56140 "EHLO smtp1.u-psud.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752154Ab2BWR2A (ORCPT ); Thu, 23 Feb 2012 12:28:00 -0500 Message-ID: <4F46771F.9000200@lri.fr> (sfid-20120223_182805_305598_57B1B374) Date: Thu, 23 Feb 2012 18:27:59 +0100 From: Nicolas Cavallari MIME-Version: 1.0 To: Christian Lamparter CC: "John W. Linville" , linux-wireless@vger.kernel.org Subject: Re: [RFC] carl9170: Fix memory accounting when sta is in power-save mode. References: <1330012414-26559-1-git-send-email-cavallar@lri.fr> <201202231752.44125.chunkeey@googlemail.com> In-Reply-To: <201202231752.44125.chunkeey@googlemail.com> Content-Type: text/plain; charset=ISO-8859-15 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 23/02/2012 17:52, Christian Lamparter wrote: > On Thursday, February 23, 2012 04:53:34 PM Nicolas Cavallari wrote: >> While this seems to fix my problem, there could still be problems remaining >> in this code path. Particularly carl9170_tx_status will do lots of things >> like incrementing counters and waking up mac80211 queues... > That should be alright. As a rule of thumb, for every call to > carl9170_tx_accounting [called by carl9170_op_tx tx handler] > we need to call carl9170_tx_status. If the station is still in > ps mode, mac80211 will cache the station's frames and sets > the TIM bits. Part of the reason i wrote this, is because, while this patch fixes the memory accounting problem and prevent the AP from stopping working, the powersaving station sometimes cannot communicate with the AP anymore (other stations can). The station uses ath9k, and is just really doing a background scan. The first traces that i have just indicate that the station entered powersave mode, then sends probe requests and probe requests directed to the AP, then sends authentication requests to the AP (?), but the AP does not respond to any of them... I did thoses traces with an external device in monitor mode, so i may have missed some packets. I'll try with a monitor vif on the AP interface.