Return-path: Received: from nbd.name ([46.4.11.11]:50244 "EHLO nbd.name" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751063Ab2BPHii (ORCPT ); Thu, 16 Feb 2012 02:38:38 -0500 Message-ID: <4F3CB274.1080800@openwrt.org> (sfid-20120216_083845_755479_5B9C7D39) Date: Thu, 16 Feb 2012 08:38:28 +0100 From: Felix Fietkau MIME-Version: 1.0 To: Mohammed Shafi Shajakhan CC: "John W. Linville" , Mohammed@venema.h4ckr.net, ath9k-devel@lists.ath9k.org, linux-wireless@vger.kernel.org, Rodriguez Luis Subject: Re: [RFC] ath9k: remove rx_bufptr References: <1329375781-4902-1-git-send-email-mohammed@qca.qualcomm.com> In-Reply-To: <1329375781-4902-1-git-send-email-mohammed@qca.qualcomm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 2012-02-16 8:03 AM, Mohammed Shafi Shajakhan wrote: > From: Mohammed Shafi Shajakhan > > it does not seems to used for anything > > Signed-off-by: Mohammed Shafi Shajakhan > --- > drivers/net/wireless/ath/ath9k/ath9k.h | 1 - > drivers/net/wireless/ath/ath9k/recv.c | 4 ---- > 2 files changed, 0 insertions(+), 5 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath9k/ath9k.h b/drivers/net/wireless/ath/ath9k/ath9k.h > index 171ccf7..603f686 100644 > --- a/drivers/net/wireless/ath/ath9k/ath9k.h > +++ b/drivers/net/wireless/ath/ath9k/ath9k.h > @@ -311,7 +311,6 @@ struct ath_rx { > spinlock_t rxbuflock; > struct list_head rxbuf; > struct ath_descdma rxdma; > - struct ath_buf *rx_bufptr; > struct ath_rx_edma rx_edma[ATH9K_RX_QUEUE_MAX]; > > struct sk_buff *frag; > diff --git a/drivers/net/wireless/ath/ath9k/recv.c b/drivers/net/wireless/ath/ath9k/recv.c > index 7e1a91a..c9612d9 100644 > --- a/drivers/net/wireless/ath/ath9k/recv.c > +++ b/drivers/net/wireless/ath/ath9k/recv.c > @@ -224,9 +224,6 @@ static void ath_rx_edma_cleanup(struct ath_softc *sc) > } > > INIT_LIST_HEAD(&sc->rx.rxbuf); > - > - kfree(sc->rx.rx_bufptr); > - sc->rx.rx_bufptr = NULL; > } > Take a look at this part. It's used for avoiding a memleak, so please keep it ;)