Message-ID: <1329899891.5143.34.camel@joe2Laptop> (sfid-20120222_093818_511859_F0BA7078)
Subject: Re: [PATCH 25/26] ath9k_hw: MCI whitespace/debug cleanup
From: Joe Perches <joe@perches.com>
To: Sujith Manoharan <c_manoha@qca.qualcomm.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
	ath9k-devel@lists.ath9k.org
Date: Wed, 22 Feb 2012 00:38:11 -0800
In-Reply-To: <20292.38229.300584.953289@gargle.gargle.HOWL>
References: <20292.38229.300584.953289@gargle.gargle.HOWL>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Sender: linux-wireless-owner@vger.kernel.org

On Wed, 2012-02-22 at 12:42 +0530, Sujith Manoharan wrote:
> This patch fixes indentation and the general coding style
> in ar9003_mci.c. Also, minimize the amount of debug log
> output generated by MCI.
[]
> diff --git a/drivers/net/wireless/ath/ath9k/ar9003_mci.c b/drivers/net/wireless/ath/ath9k/ar9003_mci.c
[]
> @@ -35,13 +35,10 @@ static int ar9003_mci_wait_for_interrupt(struct ath_hw *ah, u32 address,
>  	struct ath_common *common = ath9k_hw_common(ah);
>  
>  	while (time_out) {
> -
>  		if (REG_READ(ah, address) & bit_position) {
> -
>  			REG_WRITE(ah, address, bit_position);

A for loop with a test/continue would reduce indentation.
Might fix a bug too if timeout is ever negative.

	for (; timeout > 0; udelay(10), timeout -= 10) {
		if (!(REG_READ(ah, address) & bit_position))
			continue;
		etc...