Return-path: Received: from www.linutronix.de ([62.245.132.108]:59288 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754648Ab2CFTbv (ORCPT ); Tue, 6 Mar 2012 14:31:51 -0500 Date: Tue, 6 Mar 2012 20:31:46 +0100 (CET) From: Thomas Gleixner To: Linus Torvalds cc: Stefan Lippers-Hollmann , Sven Joachim , Greg KH , LKML , stable@vger.kernel.org, Andrew Morton , Alan Cox , Jonathan Nieder , linux-wireless@vger.kernel.org, Stefano Brivio Subject: Re: [ 57/72] genirq: Unmask oneshot irqs when thread was not woken In-Reply-To: Message-ID: (sfid-20120306_203210_740456_AC2C4165) References: <20120228010511.GA8453@kroah.com> <20120228010434.412979550@linuxfoundation.org> <87hay4dqjr.fsf@turtle.gmx.de> <201203050143.24541.s.L-H@gmx.de> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, 6 Mar 2012, Thomas Gleixner wrote: > On Tue, 6 Mar 2012, Thomas Gleixner wrote: > > > On Mon, 5 Mar 2012, Linus Torvalds wrote: > > > > > Thomas, should we just plan on reverting that commit from mainline? It > > > clearly causes regressions. > > > > Give me a day or two to figure out why it breaks stuff. I have no idea > > why it should wreckage anything. > > Hmm. This is interesting. The b43 driver has a primary handler which > can return IRQ_NONE. So up to that change the interrupt line was kept > disabled when that happened. Possibly the driver relies on that > behaviour. Digging for a machine with a b43. Does not reproduce. Now I was looking at the driver again, it does not use IRQ_ONESHOT anyway. So for handle_fasteoi_irq() this patch is actually a NOOP. So the only affected handler would be handle_level_irq(). Still can't see how it changes the !IRQ_ONESHOT behaviour :( Stephan, Sven: Can you please provide the output of /proc/interrupts ? Thanks, tglx