Message-ID: <1332346257.3500.9.camel@deadeye> (sfid-20120321_171117_840956_1C9E56E8)
Subject: Re: [PATCH v3 4/4] ath9k:  Support ethtool getstats api.
From: Ben Hutchings <bhutchings@solarflare.com>
To: Sujith Manoharan <c_manoha@qca.qualcomm.com>
CC: Ben Greear <greearb@candelatech.com>,
	<linux-wireless@vger.kernel.org>, <netdev@vger.kernel.org>
Date: Wed, 21 Mar 2012 16:10:57 +0000
In-Reply-To: <20329.32334.162938.169995@gargle.gargle.HOWL>
References: <1332183105-4447-1-git-send-email-greearb@candelatech.com>
	 <1332183105-4447-4-git-send-email-greearb@candelatech.com>
	 <4F684301.9040006@openwrt.org> <4F68B4AA.3070306@candelatech.com>
	 <20329.32334.162938.169995@gargle.gargle.HOWL>
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Sender: linux-wireless-owner@vger.kernel.org

On Wed, 2012-03-21 at 12:37 +0530, Sujith Manoharan wrote:
> Ben Greear wrote:
> > I'd like to gather at least most stats always, so ethtool can work regardless
> > of debugfs.  But, that can be follow on patches in my opinion.  If it turns
> > out that we need another config option for this, then that is fine too.
> 
> It would be good to have an option to compile this out. The information is
> available via the debugfs interface, so this is basically duplicating things.
> On APs using OpenWRT, debugfs is enabled by default, so we can just read
> the debugfs files.

ethtool is the normal way to expose extended network stats, so the
debugfs interface should be dropped in favour of this.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.