Return-path: Received: from charlotte.tuxdriver.com ([70.61.120.58]:39134 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756252Ab2CETrH (ORCPT ); Mon, 5 Mar 2012 14:47:07 -0500 Date: Mon, 5 Mar 2012 14:33:48 -0500 From: "John W. Linville" To: Felix Fietkau Cc: linux-wireless@vger.kernel.org, mcgrof@qca.qualcomm.com, rmanohar@qca.qualcomm.com Subject: Re: [PATCH 3.3 1/4] Revert "ath9k_hw: Fix false tx hung detection in AR9003 chips" Message-ID: <20120305193348.GE18128@tuxdriver.com> (sfid-20120305_204711_700528_C7E1B9EB) References: <1330369122-60220-1-git-send-email-nbd@openwrt.org> <20120229180825.GB13733@tuxdriver.com> <4F4E6D6C.5010605@openwrt.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <4F4E6D6C.5010605@openwrt.org> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, Feb 29, 2012 at 07:24:44PM +0100, Felix Fietkau wrote: > On 2012-02-29 7:08 PM, John W. Linville wrote: > > On Mon, Feb 27, 2012 at 07:58:39PM +0100, Felix Fietkau wrote: > >> The approach of this change is flawed, as it triggers tx status processing > >> from more callsites, yet the chips only have one global tx status queue. > >> Subsequent patches will properly fix the issue that this one tried to address. > >> > >> Signed-off-by: Felix Fietkau > > > > How flawed is the current approach? That commit looks like it has been > > around for months already. Does it really _need_ to be fixed in 3.3? > It only slightly reduces the severity of the issue it tried to address, > while adding some ugly race conditions. It is not possible to properly > fix the issue without a revert of that commit, so I really would like to > see this patch series in 3.3. I am happy to take this series for 3.4, but it seems quite late for 3.3. We have been living with it for a while already. John -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready.