Return-path: Received: from moutng.kundenserver.de ([212.227.126.187]:52936 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756568Ab2CQQoV (ORCPT ); Sat, 17 Mar 2012 12:44:21 -0400 From: Arnd Bergmann To: Mircea Gherzan Subject: Re: [PATCH] wl12xx: fix DMA-API-related warnings Date: Sat, 17 Mar 2012 16:44:14 +0000 Cc: Luciano Coelho , "John W. Linville" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <1332001592-17074-1-git-send-email-mgherzan@gmail.com> In-Reply-To: <1332001592-17074-1-git-send-email-mgherzan@gmail.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Message-Id: <201203171644.14573.arnd@arndb.de> (sfid-20120317_174522_372224_C66A38E5) Sender: linux-wireless-owner@vger.kernel.org List-ID: On Saturday 17 March 2012, Mircea Gherzan wrote: > int wl1271_event_handle(struct wl1271 *wl, u8 mbox_num) > { > - struct event_mailbox mbox; > - int ret; > + struct event_mailbox *mbox; > + int ret = 0; > > wl1271_debug(DEBUG_EVENT, "EVENT on mbox %d", mbox_num); > > if (mbox_num > 1) > return -EINVAL; > > + /* no GFP_ATOMIC: we're called from the threaded IRQ handler */ > + mbox = kmalloc(sizeof(*mbox), GFP_DMA); > + > /* first we read the mbox descriptor */ > - wl1271_read(wl, wl->mbox_ptr[mbox_num], &mbox, > - sizeof(struct event_mailbox), false); > + wl1271_read(wl, wl->mbox_ptr[mbox_num], mbox, sizeof(*mbox), false); > > /* process the descriptor */ > - ret = wl1271_event_process(wl, &mbox); > + ret = wl1271_event_process(wl, mbox); > if (ret < 0) > - return ret; > + goto out; > > /* then we let the firmware know it can go on...*/ > wl1271_write32(wl, ACX_REG_INTERRUPT_TRIG, INTR_TRIG_EVENT_ACK); > > - return 0; > +out: > + kfree(mbox); > + return ret; > } I think it would be better here to put another field into struct wl1271 to hold the mailbox. There is no point allocating and freeing the field every time you get into the interrupt handler. Arnd