Return-path: Received: from charlotte.tuxdriver.com ([70.61.120.58]:54590 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932409Ab2COPRL (ORCPT ); Thu, 15 Mar 2012 11:17:11 -0400 Date: Thu, 15 Mar 2012 11:03:14 -0400 From: "John W. Linville" To: Johannes Berg Cc: Jussi Kivilinna , linux-wireless Subject: Re: [PATCH] rndis_wlan: don't report station signal Message-ID: <20120315150313.GD31717@tuxdriver.com> (sfid-20120315_161714_837232_2744F88A) References: <1331820805.3432.17.camel@jlt3.sipsolutions.net> <20120315142527.GC31717@tuxdriver.com> <1331822834.3432.22.camel@jlt3.sipsolutions.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1331822834.3432.22.camel@jlt3.sipsolutions.net> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thu, Mar 15, 2012 at 03:47:14PM +0100, Johannes Berg wrote: > On Thu, 2012-03-15 at 10:25 -0400, John W. Linville wrote: > > On Thu, Mar 15, 2012 at 03:13:25PM +0100, Johannes Berg wrote: > > > From: Johannes Berg > > > > > > The station signal value is supposed to be in dBm > > > which the device can't give, so don't report it. > > > > > > Signed-off-by: Johannes Berg > > > > Won't this break functionality for users of this device? > > I don't know if it breaks functionality, but filling in values in the > wrong units doesn't seem like a good plan. No, but if it isn't actually hurting anyting then I would rather change a comment or two (and perhaps augment the nl80211 code) than to simply break things for users. FWIW, cfg80211_wireless_stats has been able to cope with the unspecified units since it was implemented in commit 8990646d. Maybe that was a bug but it is a user-visible one that has been around for years now... John -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready.