Return-path: Received: from mms3.broadcom.com ([216.31.210.19]:1734 "EHLO MMS3.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758283Ab2CAPQO (ORCPT ); Thu, 1 Mar 2012 10:16:14 -0500 Message-ID: <4F4F92B2.4060708@broadcom.com> (sfid-20120301_161618_616790_DCFC1022) Date: Thu, 1 Mar 2012 16:16:02 +0100 From: "Arend van Spriel" MIME-Version: 1.0 To: "Hauke Mehrtens" cc: "linux-wireless@vger.kernel.org" , "Saul St. John" , "Rafal Milecki" , "Larry Finger" Subject: Re: [RFC] bcma: add support for on-chip OTP memory used for SPROM storage References: <1330033977-5741-1-git-send-email-arend@broadcom.com> <4F48D997.1060400@hauke-m.de> <4F4B571E.7040704@broadcom.com> <4F4D34FA.8070800@hauke-m.de> <4F4F83D2.8030101@broadcom.com> <4F4F8934.6070101@hauke-m.de> In-Reply-To: <4F4F8934.6070101@hauke-m.de> Content-Type: text/plain; charset=iso-8859-1; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 03/01/2012 03:35 PM, Hauke Mehrtens wrote: > On 03/01/2012 03:12 PM, Arend van Spriel wrote: >> On 02/28/2012 09:11 PM, Hauke Mehrtens wrote: >>> On 02/27/2012 11:12 AM, Arend van Spriel wrote: >>>> On 02/25/2012 01:52 PM, Hauke Mehrtens wrote: >>>>> I will test you patch on my device soon and will report if something is >>>>> wrong. If you are sending a non RFC patch in the next days I would >>>>> rebase my patch onto yours. The code searching in the SoCs flash chip >>>>> will be added to run if bcma_sprom_onchip_available() returns false. >>>> >>>> Appreciate any testing on SoCs. I think I will need some time to modify >>>> brcmsmac so let your patch go first. >>> >>> The sprom part of my SoC is working with this patch on top of my sprom >>> patches, but it uses the sprom from flash/nvram for both wifi devices >>> (one integrated in the bCM4716 and the other a BCM43224 connected to the >>> PCIe host controller of the BCM4716). >>> For my BCM4716 bcma_sprom_ext_available() and >>> bcma_sprom_onchip_available() are returning false and for the BCM43224 >>> bcma_sprom_ext_available() is returning false and >>> bcma_sprom_onchip_offset() 0. >> >> Thanks, Hauke >> >> Did the BCM43224 come with the router. If so I am assuming the onchip is >> not used and the system relies on flash/nvram completely. I will inform >> whether my assumption is correct. > Yes the BCM43224 is direly soldered onto the board where also the > BCM4716 is on, there is no physical PCIe port or something like this. > The nvram on the flash chip contains the sprom for this devices, one set > of variables in the nvram has the prefix pci/1/1/ (for the BCM43224 with > the options for 5GHz only) and the other has sb/1/ (for the BCM4716 with > the options for 2.4 GHz only). > > It is this device: http://infodepot.wikia.com/wiki/Netgear_WNDR3400 > > Hauke > You made me curious so I followed the link. It says BCM4718. Gr. AvS