Return-path: Received: from mail-ww0-f44.google.com ([74.125.82.44]:48937 "EHLO mail-ww0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758506Ab2CFIw2 convert rfc822-to-8bit (ORCPT ); Tue, 6 Mar 2012 03:52:28 -0500 Received: by wgbdr13 with SMTP id dr13so4300180wgb.1 for ; Tue, 06 Mar 2012 00:52:27 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <4F548474.10703@broadcom.com> References: <1330033977-5741-1-git-send-email-arend@broadcom.com> <4F48D997.1060400@hauke-m.de> <4F4B571E.7040704@broadcom.com> <4F4D34FA.8070800@hauke-m.de> <4F548474.10703@broadcom.com> Date: Tue, 6 Mar 2012 09:52:27 +0100 Message-ID: (sfid-20120306_095231_778860_11885D90) Subject: Re: [RFC] bcma: add support for on-chip OTP memory used for SPROM storage From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= To: Arend van Spriel Cc: Hauke Mehrtens , "linux-wireless@vger.kernel.org" , "Saul St. John" , Larry Finger Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: W dniu 5 marca 2012 10:16 użytkownik Arend van Spriel napisał: > On 03/03/2012 11:44 PM, Rafał Miłecki wrote: >> >> 2012/2/28 Hauke Mehrtens: >>> >>> On 02/27/2012 11:12 AM, Arend van Spriel wrote: >>>> >>>> >>>> Appreciate any testing on SoCs. I think I will need some time to modify >>>> brcmsmac so let your patch go first. >>> >>> >>> The sprom part of my SoC is working with this patch on top of my sprom >>> patches, but it uses the sprom from flash/nvram for both wifi devices >>> (one integrated in the bCM4716 and the other a BCM43224 connected to the >>> PCIe host controller of the BCM4716). >>> For my BCM4716 bcma_sprom_ext_available() and >>> bcma_sprom_onchip_available() are returning false and for the BCM43224 >>> bcma_sprom_ext_available() is returning false and >>> bcma_sprom_onchip_offset() 0. >> >> >> I guess that's wrong...? So is there something wrong with the Arend's >> patch causing this regression? Or was this wrong even earlier? >> >> I'm not sure if I should test this patch against my cards or should I >> wait for V2. >> > > Hi Rafał, > > It is not wrong. I asked Hauke a question about his router regarding this. > The story for routers is that sprom data for both cards resides in > nvram/flash, ie. the fallback sprom source in Hauke's patch. OK, I gave it a try, it works with my BCM43224, nice work. > Not sure why > that bcma patch has not yet made it into wireless-next. Have you sent it in final form and without RFC? I don't think I've received it. -- Rafał