Return-path: Received: from victor.provo.novell.com ([137.65.250.26]:58739 "EHLO victor.provo.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965091Ab2CUG5c convert rfc822-to-8bit (ORCPT ); Wed, 21 Mar 2012 02:57:32 -0400 Received: by bkcik5 with SMTP id ik5so630096bkc.19 for ; Tue, 20 Mar 2012 23:57:26 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1332246689.3329.16.camel@jlt3.sipsolutions.net> References: <1332224377.3329.1.camel@jlt3.sipsolutions.net> <1332246689.3329.16.camel@jlt3.sipsolutions.net> Date: Wed, 21 Mar 2012 14:57:26 +0800 Message-ID: (sfid-20120321_075743_046792_A7769D05) Subject: Re: About the .start function in ieee80211_ops. From: Matt Chen To: Johannes Berg Cc: users@rt2x00.serialmonkey.com, linux-wireless Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: Hi Johannes, 2012/3/20 Johannes Berg : > On Tue, 2012-03-20 at 20:29 +0800, Matt Chen wrote: >> Hi Johannes, >> >> 2012/3/20 Johannes Berg : >> > On Tue, 2012-03-20 at 14:02 +0800, Matt Chen wrote: >> >> Hi all, >> >> I have a issue recently for rt2800pci, the way to duplicate this is >> >> 1. Press function key to set rfkill hard blocked, it would cause >> >> driver to power off. >> >> 2. reboot >> >> 3. find when load the driver (rt2800pci), it would stop in "Registered >> >> led device: rt2800pci-phy0::quality". >> >> >> >> Here you would find the rfkill_poll function is not started to work, >> >> also the rt2x00mac_start() registered in rt2800pci_mac80211_ops >> >> structure is not yet be executed. >> >> My question is when or what condition the rt2x00mac_start() ?would be >> >> running, because if it is not yet executed, then it would not be able >> >> to load the firmware in rt2x00lib_start(). >> > >> > That's a bug in the driver then -- it should probably start the rfkill >> > stuff without mac80211's start() command. start() is only called when >> > the first interface comes up, but that will never happen if it's in >> > rfkill block. >> Do you have any idea which part of code would make the first interface >> comes up ? ?:) >> Would that be in cfg80211 ? > > No code? You, as the user, running "ip link set wlan0 up" or > network-manager doing something similar etc. Big thank you for the information. :) For rt2x00, is this the only way to make the driver executing the .run function in ieee80211_ops structure definition ? > johannes > -- Thank you.