Return-path: Received: from nbd.name ([46.4.11.11]:40575 "EHLO nbd.name" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752299Ab2CCOz2 (ORCPT ); Sat, 3 Mar 2012 09:55:28 -0500 Message-ID: <4F5230D8.8040104@openwrt.org> (sfid-20120303_155558_112784_7CE3E021) Date: Sat, 03 Mar 2012 15:55:20 +0100 From: Felix Fietkau MIME-Version: 1.0 To: Mohammed Shafi CC: linux-wireless@vger.kernel.org, linville@tuxdriver.com, mcgrof@qca.qualcomm.com Subject: Re: [PATCH 3/5] ath9k: remove rssi/antenna information from recv debug stats References: <1330784226-65563-1-git-send-email-nbd@openwrt.org> <1330784226-65563-2-git-send-email-nbd@openwrt.org> <1330784226-65563-3-git-send-email-nbd@openwrt.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 2012-03-03 3:46 PM, Mohammed Shafi wrote: > On Sat, Mar 3, 2012 at 7:47 PM, Felix Fietkau wrote: >> The way this is implemented (simply storing the last value) is absolutely >> worthless for debugging anything, and the same information is also available >> through the MAC sample feature, so there's no point in keeping this around. > > :) :) please keep this, we were debugging antenna diversity related > issues in AR9485 with this stats. the antenna switching never > happened, then with these stats we found that the rss1 seems to be > always negative, same result with the windows driver also, then later > found its a EEPROM related issue. You can already get the antenna from the radiotap information of a monitor mode interface, which I think is much more useful than this limited debugfs parameter. If you really need this in debugfs, it could also be added to the MAC sampling, though I think that one is rather limited as well. - Felix