Return-path: Received: from mail-iy0-f174.google.com ([209.85.210.174]:58075 "EHLO mail-iy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752958Ab2CQVO4 (ORCPT ); Sat, 17 Mar 2012 17:14:56 -0400 Message-ID: <4F64FECD.9000802@lwfinger.net> (sfid-20120317_221521_165969_241F0FFF) Date: Sat, 17 Mar 2012 16:14:53 -0500 From: Larry Finger MIME-Version: 1.0 To: Joe Perches CC: Chaoming Li , "John W. Linville" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] rtlwifi: Use is_zero_ether_addr, remove line continuation References: <1d738d4a4dd61978f969ed4a43f2dd3717f51a19.1332011552.git.joe@perches.com> In-Reply-To: <1d738d4a4dd61978f969ed4a43f2dd3717f51a19.1332011552.git.joe@perches.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 03/17/2012 02:13 PM, Joe Perches wrote: > Use the normal kernel facilities and use %pM > to print the all zero mac address. > > Remove unnecessary line continuation. > > Signed-off-by: Joe Perches > --- > drivers/net/wireless/rtlwifi/cam.c | 5 ++--- > 1 files changed, 2 insertions(+), 3 deletions(-) ACKed-by: Larry.Finger@lwfinger.net Is there a PATCH 2/2? I did not receive it. Larry > > diff --git a/drivers/net/wireless/rtlwifi/cam.c b/drivers/net/wireless/rtlwifi/cam.c > index 5c7d579..3d8cc4a 100644 > --- a/drivers/net/wireless/rtlwifi/cam.c > +++ b/drivers/net/wireless/rtlwifi/cam.c > @@ -328,10 +328,9 @@ void rtl_cam_del_entry(struct ieee80211_hw *hw, u8 *sta_addr) > RT_TRACE(rtlpriv, COMP_SEC, DBG_EMERG, "sta_addr is NULL\n"); > } > > - if ((sta_addr[0]|sta_addr[1]|sta_addr[2]|sta_addr[3]|\ > - sta_addr[4]|sta_addr[5]) == 0) { > + if (is_zero_ether_addr(sta_addr)) { > RT_TRACE(rtlpriv, COMP_SEC, DBG_EMERG, > - "sta_addr is 00:00:00:00:00:00\n"); > + "sta_addr is %pM\n", sta_addr); > return; > } > /* Does STA already exist? */