Return-path: Received: from storm.alittletooquiet.net ([67.23.28.199]:55783 "EHLO storm.alittletooquiet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750882Ab2DESGe (ORCPT ); Thu, 5 Apr 2012 14:06:34 -0400 Date: Thu, 5 Apr 2012 14:06:33 -0400 From: Forest Bond To: Larry Finger Cc: linux-wireless@vger.kernel.org, Chaoming Li Subject: Re: [PATCH 1/2] rtl8192de: Clean up and fix 92D cut version constants and macros. Message-ID: <20120405180633.GG21869@alittletooquiet.net> (sfid-20120405_200638_003429_1A34A9EA) References: <20120402142525.GA20611@alittletooquiet.net> <4F79E7B9.7060504@lwfinger.net> <20120402175745.GE20611@alittletooquiet.net> <4F79EA18.9060502@lwfinger.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="kVXhAStRUZ/+rrGn" In-Reply-To: <4F79EA18.9060502@lwfinger.net> Sender: linux-wireless-owner@vger.kernel.org List-ID: --kVXhAStRUZ/+rrGn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Larry, On Mon, Apr 02, 2012 at 01:04:08PM -0500, Larry Finger wrote: > On 04/02/2012 12:57 PM, Forest Bond wrote: > >On Mon, Apr 02, 2012 at 12:54:01PM -0500, Larry Finger wrote: > >>On 04/02/2012 09:25 AM, Forest Bond wrote: > >>>From: Forest Bond > >>> > >>>The previous definitions included both {B,C,D,E}_CUT_VERSION and > >>>CHIP_92D_{C,D}_CUT with conflicting values for the C and D cut version= s, > >>>and literal hex values were used in the IS_92D_{C,D,E}_CUT macros. So > >>>we clean all this up and in doing so enable cut-specific code paths for > >>>cuts C and D, which would not have been executed because the > >>>CHIP_92D_{C,D}_CUT constants were wrong and the cut version was thus > >>>recorded incorrectly. > >>> > >>>Signed-off-by: Forest Bond > >> > >>This patch does not apply to the wireless-testing tree. That is the > >>one you are supposed to use. > >> > >>Patch #2 also fails to apply. In addition, your mailer mangled a line. > > > >Sorry for the trouble. I'll resend a little later this afternoon. >=20 > No problem for me. I was able to fix everything but the mangling with wig= gle. I just resent both patches, including the changes you requested to the first one. Turns out GPG was causing all of the issues above, so I didn't sign t= he resent patches. Thanks, Forest --=20 Forest Bond http://www.alittletooquiet.net http://www.rapidrollout.com --kVXhAStRUZ/+rrGn Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iEYEARECAAYFAk993ykACgkQRO4fQQdv5Ayw3ACdFU5m0Q3nLJzGfJt5RgZy2lt0 bIIAn3zbATBdpFRTrlgW+28EglZPLfnq =bKOh -----END PGP SIGNATURE----- --kVXhAStRUZ/+rrGn--