Return-path: Received: from na3sys009aog108.obsmtp.com ([74.125.149.199]:42082 "EHLO na3sys009aog108.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751267Ab2DQFa0 (ORCPT ); Tue, 17 Apr 2012 01:30:26 -0400 Received: by lahc1 with SMTP id c1so4646720lah.26 for ; Mon, 16 Apr 2012 22:30:23 -0700 (PDT) Message-ID: <1334640620.27247.7.camel@cumari> (sfid-20120417_073043_079356_001CEF92) Subject: Re: [PATCH -next] wireless: TI wlxxx depends on MAC80211 From: Luciano Coelho To: Randy Dunlap Cc: Stephen Rothwell , linux-next@vger.kernel.org, LKML , Andrew Morton , linux-wireless@vger.kernel.org, "John W. Linville" Date: Tue, 17 Apr 2012 08:30:20 +0300 In-Reply-To: <4F8C784B.2040402@xenotime.net> References: <20120416161121.261ba4e7e38989173accfb16@canb.auug.org.au> <4F8C784B.2040402@xenotime.net> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: Hi Randy, On Mon, 2012-04-16 at 12:51 -0700, Randy Dunlap wrote: > From: Randy Dunlap > > wl12xx build fails with many undefined symbol errors when MAC80211 > and CFG80211 are not enabled, so make WLCORE and WL12XX depend > on MAC80211 (which already depends on CFG80211). > > Here are a few of the many build errors: > [...] > Signed-off-by: Randy Dunlap > Cc: Luciano Coelho > Cc: linux-wireless@vger.kernel.org > Cc: "John W. Linville" > --- Thanks for the patch! > --- linux-next-20120416.orig/drivers/net/wireless/ti/wl12xx/Kconfig > +++ linux-next-20120416/drivers/net/wireless/ti/wl12xx/Kconfig > @@ -1,5 +1,6 @@ > config WL12XX > tristate "TI wl12xx support" > + depends on MAC80211 > select WLCORE Do we really need this one? wl12xx selects WLCORE which in turn depends on MAC80211 (with your change below). Maybe we don't need this? > ---help--- > This module adds support for wireless adapters based on TI wl1271, > --- linux-next-20120416.orig/drivers/net/wireless/ti/wlcore/Kconfig > +++ linux-next-20120416/drivers/net/wireless/ti/wlcore/Kconfig > @@ -1,6 +1,6 @@ > config WLCORE > tristate "TI wlcore support" > - depends on WL_TI && GENERIC_HARDIRQS > + depends on WL_TI && GENERIC_HARDIRQS && MAC80211 > depends on INET > select FW_LOADER > ---help--- -- Cheers, Luca.