Return-path: Received: from mail-wi0-f178.google.com ([209.85.212.178]:62538 "EHLO mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966078Ab2DLVoq (ORCPT ); Thu, 12 Apr 2012 17:44:46 -0400 MIME-Version: 1.0 In-Reply-To: References: <20120411231102.GA6404@kroah.com> <20120412002927.GA23167@kroah.com> <20120412011313.GA23764@kroah.com> <20120412144626.GA14868@kroah.com> From: Linus Torvalds Date: Thu, 12 Apr 2012 14:44:24 -0700 Message-ID: (sfid-20120412_234502_244827_0F7102CB) Subject: Re: [ 00/78] 3.3.2-stable review To: Felipe Contreras Cc: Greg KH , Sergio Correia , linux-kernel@vger.kernel.org, stable@vger.kernel.org, akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk, linux-wireless Mailing List , Sujith Manoharan , "ath9k-devel@lists.ath9k.org" , "John W. Linville" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thu, Apr 12, 2012 at 2:34 PM, Linus Torvalds wrote: > > So just reverting it from stable, *WITHOUT LEARNING THE LESSON*, is > not a no-op at all, it's a sign of being a f*cking moron. Btw, the revert is now in my tree (commit 011afa1ed8c4), and marked for stable. So *now* Greg can revert it from stable too. But the important lesson to everybody should be that "we don't lose fixes from -stable". If a problem was found in stable, it needs to be fixed upstream. In fact, quite often people *do* find problems in stable, because it tends to have more users more quickly than mainline. That makes it really really important to make sure that those problems get fixed upstream, and not hidden in stable due to some kind of dieseased "it's a no-op to revert it" thinking. End of story. Linus