Return-path: Received: from mail.neratec.com ([80.75.119.105]:56279 "EHLO mail.neratec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750910Ab2DMPKs (ORCPT ); Fri, 13 Apr 2012 11:10:48 -0400 Message-ID: <4F8841F2.7030105@neratec.com> (sfid-20120413_171053_188942_288CD238) Date: Fri, 13 Apr 2012 17:10:42 +0200 From: Zefir Kurtisi MIME-Version: 1.0 To: Felix Fietkau CC: linux-wireless@vger.kernel.org, linville@tuxdriver.com, mcgrof@qca.qualcomm.com Subject: Re: [PATCH 1/4] ath9k_hw: remove enable_32kHz_clock References: <1334262958-90777-1-git-send-email-nbd@openwrt.org> In-Reply-To: <1334262958-90777-1-git-send-email-nbd@openwrt.org> Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 04/12/2012 10:35 PM, Felix Fietkau wrote: > It is unused and useless > > Signed-off-by: Felix Fietkau > --- > drivers/net/wireless/ath/ath9k/hw.c | 1 - > drivers/net/wireless/ath/ath9k/hw.h | 5 ----- > 2 files changed, 0 insertions(+), 6 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath9k/hw.c b/drivers/net/wireless/ath/ath9k/hw.c > index d1345a8..6fa8128 100644 > --- a/drivers/net/wireless/ath/ath9k/hw.c > +++ b/drivers/net/wireless/ath/ath9k/hw.c > @@ -445,7 +445,6 @@ static void ath9k_hw_init_defaults(struct ath_hw *ah) > AR_STA_ID1_MCAST_KSRCH; > if (AR_SREV_9100(ah)) > ah->sta_id1_defaults |= AR_STA_ID1_AR9100_BA_FIX; > - ah->enable_32kHz_clock = DONT_USE_32KHZ; > ah->slottime = ATH9K_SLOT_TIME_9; > ah->globaltxtimeout = (u32) -1; > ah->power_mode = ATH9K_PM_UNDEFINED; > diff --git a/drivers/net/wireless/ath/ath9k/hw.h b/drivers/net/wireless/ath/ath9k/hw.h > index aa1680a..d85a8de 100644 > --- a/drivers/net/wireless/ath/ath9k/hw.h > +++ b/drivers/net/wireless/ath/ath9k/hw.h > @@ -762,11 +762,6 @@ struct ath_hw { > > u32 sta_id1_defaults; > u32 misc_mode; > - enum { > - AUTO_32KHZ, > - USE_32KHZ, > - DONT_USE_32KHZ, > - } enable_32kHz_clock; > > /* Private to hardware code */ > struct ath_hw_private_ops private_ops; Hi Felix, that went already in as part of '[PATCH] ath9k: remove dead code' some days ago [1]. Cheers, Zefir [1] http://article.gmane.org/gmane.linux.kernel.wireless.general/88559