Return-path: Received: from serv04.lahn.de ([213.239.197.57]:50859 "EHLO serv04.lahn.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753711Ab2DIODj (ORCPT ); Mon, 9 Apr 2012 10:03:39 -0400 Date: Mon, 9 Apr 2012 16:03:22 +0200 From: Michael Leun To: Mohammed Shafi Cc: Ben Greear , casteyde.christian@free.fr, Kelly Anderson , "ath9k-devel@lists.ath9k.org" , Linux Kernel Mailing List , Felix Fietkau , linux-wireless Mailing List , Sergio Correia Subject: Re: 3.4-rc ath9k regression (Re: [ath9k-devel] 3.3.1 ath9k regression) Message-ID: <20120409160322.6b7b8c67@xenia.leun.net> (sfid-20120409_160355_987889_64C20587) In-Reply-To: <20120409122549.7469543a@xenia.leun.net> References: <4F7A8EB7.4060200@silka.with-linux.com> <4F7A9D5C.8040402@silka.with-linux.com> <4F7AAAD9.2040307@silka.with-linux.com> <4F7AB6FE.3080009@silka.with-linux.com> <20120403200306.0afbb48b@xenia.leun.net> <20120404235104.682cfad3@xenia.leun.net> <4F7DE3A4.1040705@candelatech.com> <4F7F52BD.7060906@candelatech.com> <20120409010816.36244f17@xenia.leun.net> <20120409122549.7469543a@xenia.leun.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, 9 Apr 2012 12:25:49 +0200 Michael Leun wrote: > On Mon, 9 Apr 2012 11:58:06 +0530 > Mohammed Shafi wrote: > > > On Mon, Apr 9, 2012 at 4:38 AM, Michael Leun > > wrote: > > > After an suspend to disk / resume cycle (in kernel suspend to > > > disk, openSuSE) with 3.4-rc2 my ath9k wireless does not ping > > > anymore. > > > > > > Output of iwconfig wlan0 looks just as usual (associated to AP). > > > > > > iwconfig wlan0 essid fixes this (causes an > > > deauthenticate/authenticate with AP) - then connectivity is there > > > again. > > > > > > Guess what: "Of course" does not happen when reverting > > > c1afdaff90538ef085b756454f12b29575411214 ath9k: fix going to > > > full-sleep on PS idle. > > > > > > So, in my opinion it should be seriously considered to revert that > > > patch until it is fully understood what is going on and why. > > > > please try with the attached patch to see if it helps. > > Yes, this patch helps with the issue I see in 3.4-rc2 described above. Sorry, but I have to partially rectify that: It works, if the time the machine was suspended is short, as it was when I did that testing. But I noticed it failing, when the machine was hibernated for some hours. I easily can reproduce that, when I reboot the AP while the notebook is down (btw: AP is TP-LINK TL-WR1043ND running OpenWRT backfire 10.03.1, also using ath9k). When I do this (hibernate notebook, reboot AP, resume notebook check connectivity) with 3.4-rc2 and your test.patch it fails in 100% of cases. With 3.4-rc2 and c1afdaff90538ef085b756454f12b29575411214 reverted the same works in 100% of cases. > But I agree with Ben and Sergio that it does NOT help with the issue > in 3.3.1 we all see. I mixed up some mails and actually thought Ben had already answered regarding your patch, but that is not true. -- MfG, Michael Leun