Return-path: Received: from nbd.name ([46.4.11.11]:46509 "EHLO nbd.name" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756543Ab2DFQ4V (ORCPT ); Fri, 6 Apr 2012 12:56:21 -0400 Message-ID: <4F7F2033.4000005@openwrt.org> (sfid-20120406_185639_607540_83BAB4A3) Date: Fri, 06 Apr 2012 18:56:19 +0200 From: Felix Fietkau MIME-Version: 1.0 To: "Justin P. Mattock" CC: Sujith Manoharan , Mohammed Shafi , Linux-wireless , linux-kernel@vger.kernel.org, Linux-netdev Subject: Re: ath: DMA failed to stop in 10 ms AR_CR=0x00000024 AR_DIAG_SW=0x02000020 DMADBG_7=0x00008040 References: <4F576FD5.2050208@gmail.com> <4F577D9B.7020402@gmail.com> <4F579A88.6030503@openwrt.org> <4F61F551.5010608@gmail.com> <4F639851.5080500@gmail.com> <4F674616.8080103@gmail.com> <4F674FF5.2060406@gmail.com> <4F6751B2.1030809@openwrt.org> <4F681B78.9000207@gmail.com> <4F68235C.5090701@gmail.com> <4F682555.3020502@gmail.com> <20328.16366.166909.255035@gargle.gargle.HOWL> <4F6FA388.9080408@gmail.com> <20337.9030.686697.228453@gargle.gargle.HOWL> <4F7F1C74.7080009@gmail.com> In-Reply-To: <4F7F1C74.7080009@gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 2012-04-06 6:40 PM, Justin P. Mattock wrote: > On 03/26/2012 07:17 PM, Sujith Manoharan wrote: >> Justin P. Mattock wrote: >>> I would have to say this patch above does get rid of this crash I was >>> seeing. as a quick test I simply connect to a WPA network, then connect >>> to an open network going back and forth triggers this freeze for me >>> after applying this I am able to toggle back and forth without a freeze. >> >> Thanks for verifying. >> >> Sujith >> > > > From going through the warning message I was playing around and am > looking at: AH_UNPLUGGED .. seems if I remove this from the code I have > not seen this warning message. > is there something wrong with AH_UNPLUGGED = 0x2 ? > is this the wrong address(0x2)? > > the patch that I was using is: > > From ea8a7d6ecf8b0706f3f0521cd22cc359b20b9373 Mon Sep 17 00:00:00 2001 > From: "Justin P. Mattock" > Date: Sun, 25 Mar 2012 21:53:31 -0700 > Subject: [PATCH] ath_test > > Signed-off-by: Justin P. Mattock > > --- > drivers/net/wireless/ath/ath9k/recv.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath9k/recv.c > b/drivers/net/wireless/ath/ath9k/recv.c > index f4ae3ba..d887cee 100644 > --- a/drivers/net/wireless/ath/ath9k/recv.c > +++ b/drivers/net/wireless/ath/ath9k/recv.c > @@ -523,8 +523,7 @@ bool ath_stoprecv(struct ath_softc *sc) > sc->rx.rxlink = NULL; > spin_unlock_bh(&sc->rx.rxbuflock); > > - if (!(ah->ah_flags & AH_UNPLUGGED) && > - unlikely(!stopped)) { > + if (!(ah->ah_flags) && unlikely(!stopped)) { That patch is completely messed up - before showing the warning, it checks if ah_flags is set to 0, which will never happen with most devices. You're simply making the warning impossible to trigger. - Felix