Return-path: Received: from mail.candelatech.com ([208.74.158.172]:47282 "EHLO ns3.lanforge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750722Ab2DCEBY (ORCPT ); Tue, 3 Apr 2012 00:01:24 -0400 Message-ID: <4F7A760C.90002@candelatech.com> (sfid-20120403_060131_738071_2B056876) Date: Mon, 02 Apr 2012 21:01:16 -0700 From: Ben Greear MIME-Version: 1.0 To: Sujith Manoharan CC: "linux-wireless@vger.kernel.org" , "ath9k-devel@lists.ath9k.org" Subject: Re: deadlock in ath9k, 3.3.0+ kernel. References: <4F79D0C5.6090601@candelatech.com> <506697F5827BD842B7CB80D046EBE618929925@aphydexd01b> <4F79DAAC.6080705@candelatech.com> <20346.29723.444267.19298@gargle.gargle.HOWL> In-Reply-To: <20346.29723.444267.19298@gargle.gargle.HOWL> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 04/02/2012 08:52 PM, Sujith Manoharan wrote: > Ben Greear wrote: >> On 04/02/2012 09:34 AM, Manoharan, Sujith wrote: >>> Patch sent: http://marc.info/?l=linux-wireless&m=133282325727326&w=2 >> >> My 3.3.0 ath9k code doesn't look like that patch at all. Is some >> extra back-porting needed for 3.3.0??? >> >> >> static void ath_node_attach(struct ath_softc *sc, struct ieee80211_sta *sta, >> struct ieee80211_vif *vif) >> { >> struct ath_node *an; >> an = (struct ath_node *)sta->drv_priv; >> >> #ifdef CONFIG_ATH9K_DEBUGFS >> spin_lock(&sc->nodes_lock); >> list_add(&an->list,&sc->nodes); >> spin_unlock(&sc->nodes_lock); >> #endif >> an->sta = sta; >> an->vif = vif; >> if (sc->sc_flags& SC_OP_TXAGGR) { >> ath_tx_node_init(sc, an); >> an->maxampdu = 1<< (IEEE80211_HT_MAX_AMPDU_FACTOR + >> sta->ht_cap.ampdu_factor); >> an->mpdudensity = parse_mpdudensity(sta->ht_cap.ampdu_density); >> } >> } > > Yeah, this looks like a different issue. What does decodecode (in scripts/ in the kernel > source tree) show ? I'm updating to 3.3.1 and will see if I can reproduce the problem. It could well be that there was some initial condition that caused this..but nothing was logged to /var/log/messages, and my serial console buffer didn't show the start of the problem, so I have no way to tell. So, I'll let you know if I can hit it again. Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com