Return-path: Received: from mail-ee0-f46.google.com ([74.125.83.46]:61766 "EHLO mail-ee0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751827Ab2DUWsO (ORCPT ); Sat, 21 Apr 2012 18:48:14 -0400 Received: by eekc41 with SMTP id c41so2808521eek.19 for ; Sat, 21 Apr 2012 15:48:13 -0700 (PDT) From: Eldad Zack To: Brett Rudley , Roland Vossen , Arend van Spriel , Kan Yan , "John W. Linville" Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Eldad Zack Subject: [PATCH] [brcmsmac] "INTERMEDIATE but not AMPDU" only when tracing Date: Sun, 22 Apr 2012 00:48:04 +0200 Message-Id: <1335048484-5925-1-git-send-email-eldad@fogrefinery.com> (sfid-20120422_004831_947074_17C647B3) Sender: linux-wireless-owner@vger.kernel.org List-ID: I keep getting the following messages on the log buffer: [ 2167.097507] ieee80211 phy0: brcms_c_dotxstatus: INTERMEDIATE but not AMPDU [ 2281.331305] ieee80211 phy0: brcms_c_dotxstatus: INTERMEDIATE but not AMPDU [ 2281.332539] ieee80211 phy0: brcms_c_dotxstatus: INTERMEDIATE but not AMPDU [ 2329.876605] ieee80211 phy0: brcms_c_dotxstatus: INTERMEDIATE but not AMPDU [ 2329.877354] ieee80211 phy0: brcms_c_dotxstatus: INTERMEDIATE but not AMPDU [ 2462.280756] ieee80211 phy0: brcms_c_dotxstatus: INTERMEDIATE but not AMPDU [ 2615.651689] ieee80211 phy0: brcms_c_dotxstatus: INTERMEDIATE but not AMPDU >From the code comment I understand that this something that can - and does, quite frequently - happen. This patch demotes the message to the trace level. Signed-off-by: Eldad Zack --- drivers/net/wireless/brcm80211/brcmsmac/main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/wireless/brcm80211/brcmsmac/main.c b/drivers/net/wireless/brcm80211/brcmsmac/main.c index 231ddf4..2fc5956 100644 --- a/drivers/net/wireless/brcm80211/brcmsmac/main.c +++ b/drivers/net/wireless/brcm80211/brcmsmac/main.c @@ -847,8 +847,7 @@ brcms_c_dotxstatus(struct brcms_c_info *wlc, struct tx_status *txs) */ if (!(txs->status & TX_STATUS_AMPDU) && (txs->status & TX_STATUS_INTERMEDIATE)) { - wiphy_err(wlc->wiphy, "%s: INTERMEDIATE but not AMPDU\n", - __func__); + BCMMSG(wlc->wiphy, "INTERMEDIATE but not AMPDU\n"); return false; } -- 1.7.9.5