Message-ID: <1333566178.16978.29.camel@joe2Laptop> (sfid-20120404_210303_797472_1C83BC7B)
Subject: Re: [PATCH 2/2] ath6kl: handle concurrent AP-STA channel switches
From: Joe Perches <joe@perches.com>
To: Thomas Pedersen <c_tpeder@qca.qualcomm.com>
Cc: linux-wireless@vger.kernel.org, ath6kl-devel@qualcomm.com
Date: Wed, 04 Apr 2012 12:02:58 -0700
In-Reply-To: <1333565817-18816-2-git-send-email-c_tpeder@qca.qualcomm.com>
References: <1333565817-18816-1-git-send-email-c_tpeder@qca.qualcomm.com>
	 <1333565817-18816-2-git-send-email-c_tpeder@qca.qualcomm.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Sender: linux-wireless-owner@vger.kernel.org

On Wed, 2012-04-04 at 11:56 -0700, Thomas Pedersen wrote:
> If an ath6kl AP vif is beaconing on one channel, and a STA vif
> associates on a different channel, a WMI_DISCONNECT event will be sent
> to the AP vif. Make the AP vif follow the STA interface, and notify
> userspace.

trivia:

> diff --git a/drivers/net/wireless/ath/ath6kl/cfg80211.c b/drivers/net/wireless/ath/ath6kl/cfg80211.c
[]
> @@ -1015,6 +1015,19 @@ out:
>  	vif->scan_req = NULL;
>  }
>  
> +void ath6kl_cfg80211_ch_switch_notify(struct ath6kl_vif *vif, int channel,
> +				      enum wmi_phy_mode mode)
> +{
> +	enum nl80211_channel_type type;
> +
> +	ath6kl_dbg(ATH6KL_DBG_WLAN_CFG, "channel switch notify nw_type %d"
> +		   "freq %d mode %d", vif->nw_type, channel, mode);

Please coalesce formats.
If you had, you'd've seen a problem with this format.
Add a newline "\n" terminator to it too.