Return-path: Received: from nbd.name ([46.4.11.11]:38807 "EHLO nbd.name" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750990Ab2DQLGX (ORCPT ); Tue, 17 Apr 2012 07:06:23 -0400 Message-ID: <4F8D4EA8.1010602@openwrt.org> (sfid-20120417_130627_944782_115186A8) Date: Tue, 17 Apr 2012 13:06:16 +0200 From: Felix Fietkau MIME-Version: 1.0 To: Sujith Manoharan CC: linux-wireless@vger.kernel.org, linville@tuxdriver.com, rodrigue@qca.qualcomm.com Subject: Re: [PATCH v2 7/8] ath9k_hw: disable fast channel change when changing from/to half/quarter mode References: <1334610565-37399-1-git-send-email-nbd@openwrt.org> <1334610565-37399-2-git-send-email-nbd@openwrt.org> <1334610565-37399-3-git-send-email-nbd@openwrt.org> <1334610565-37399-4-git-send-email-nbd@openwrt.org> <1334610565-37399-5-git-send-email-nbd@openwrt.org> <1334610565-37399-6-git-send-email-nbd@openwrt.org> <1334610565-37399-7-git-send-email-nbd@openwrt.org> <20364.60189.208919.748818@gargle.gargle.HOWL> In-Reply-To: <20364.60189.208919.748818@gargle.gargle.HOWL> Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 2012-04-17 6:01 AM, Sujith Manoharan wrote: > Felix Fietkau wrote: >> Signed-off-by: Felix Fietkau >> --- >> drivers/net/wireless/ath/ath9k/hw.c | 4 ++++ >> 1 files changed, 4 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/net/wireless/ath/ath9k/hw.c b/drivers/net/wireless/ath/ath9k/hw.c >> index ff8d58d..26e6083 100644 >> --- a/drivers/net/wireless/ath/ath9k/hw.c >> +++ b/drivers/net/wireless/ath/ath9k/hw.c >> @@ -1440,6 +1440,10 @@ static bool ath9k_hw_channel_change(struct ath_hw *ah, >> CHANNEL_5GHZ)); >> mode_diff = (chan->chanmode != ah->curchan->chanmode); >> >> + if ((ah->curchan->channelFlags | chan->channelFlags) & >> + (CHANNEL_HALF | CHANNEL_QUARTER)) >> + return false; >> + > > ath9k_hw_do_fastcc() is a better place where this check can be done. OK, will send a v3. - Felix