Message-ID: <BLU0-SMTP243D8B9F11F7BC3D5419A97AC2F0@phx.gbl> (sfid-20120503_070432_983355_777BC4BB)
Subject: Re: [PATCH v2 0/6] BCMA Cumulative patches from OpenWRT
From: Nathan Hintz <nlhintz@hotmail.com>
To: Arend van Spriel <arend@broadcom.com>
CC: "John W. Linville" <linville@tuxdriver.com>,
	Kalle Valo <kvalo@adurom.com>, linux-wireless@vger.kernel.org,
	hauke@hauke-m.de
Date: Wed, 2 May 2012 22:04:18 -0700
In-Reply-To: <4FA182A8.8080604@broadcom.com>
References: <BLU0-SMTP45859B1CA3415BE44C9024CAC240@phx.gbl>
	 <4F990DC1.4070305@broadcom.com> <87r4vaaezl.fsf@purkki.adurom.net>
	 <20120502181157.GC9285@tuxdriver.com> <4FA182A8.8080604@broadcom.com>
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Sender: linux-wireless-owner@vger.kernel.org

Hi:
On Wed, 2012-05-02 at 20:53 +0200, Arend van Spriel wrote:
> On 05/02/2012 08:11 PM, John W. Linville wrote:
> > On Thu, Apr 26, 2012 at 02:50:54PM +0300, Kalle Valo wrote:
> >> "Arend van Spriel" <arend@broadcom.com> writes:
> >>
> >>> On 04/26/2012 06:23 AM, Nathan Hintz wrote:
> >>>> Nathan Hintz (6):
> >>>>    bcma: Find names of non BCM cores
> >>>>    bcma: Move initialization of SPROM to prevent overwrite
> >>>>    bcma: Account for variable PCI memory base/size
> >>>>    bcma: reads/writes are always 4 bytes, so always map 4 bytes
> >>>>    bcma: Add __devexit to bcma_host_pci_remove
> >>>>    bcma: Add flush for BCMA_RESET_CTL write
> >>>>
> >>>>   arch/mips/bcm47xx/setup.c      |    4 +++
> >>>>   arch/mips/bcm47xx/sprom.c      |    2 -
> >>>>   drivers/bcma/core.c            |    1 +
> >>>>   drivers/bcma/driver_pci_host.c |   10 +++---
> >>>>   drivers/bcma/host_pci.c        |    4 +-
> >>>>   drivers/bcma/scan.c            |   54 +++++++++++++++++++++++++++++----------
> >>>>   6 files changed, 52 insertions(+), 23 deletions(-)
> >>>>
> >>>
> >>> None of these patches have any description. Some motivation for the
> >>> changes would be appreciated like 'reported problem', 'new target
> >>> support', etc.
> >>
> >> I would say that it's required. Anyone can see the diff and see what was
> >> changed, but nobody will figure out why the change was made unless it's
> >> described in the commit log. So it's important to answer the question
> >> "Why?".
> > 
> > Will we be seeing this patchset reposted with better changelogs?
> > 
> > John
> 
> Although not strongly stated by me I was certainly expecting a re-post.
> 
> Gr. AvS
> 
> 
I will repost; it will probably be a few days though.  I haven't used
GIT before other than cloning some repo's, so I have a learning curve to
overcome.

Any hints are welcome.

Thanks,
Nathan