Message-ID: <1336474641.4320.0.camel@jlt3.sipsolutions.net> (sfid-20120508_125731_723448_1DBC7673)
Subject: Re: Wireless problem in 3.4-rc5
From: Johannes Berg <johannes@sipsolutions.net>
To: Eliad Peller <eliad@wizery.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
	John Linville <linville@tuxdriver.com>,
	wireless <linux-wireless@vger.kernel.org>
Date: Tue, 08 May 2012 12:57:21 +0200
In-Reply-To: <CAB3XZEd7H683Gc_2Ytw7-LByOOGy5o_hRsuE3cjLhrONFc=6tg@mail.gmail.com> (sfid-20120508_110047_096982_8A84E6AC)
References: <4FA0405C.8050101@lwfinger.net>
	 <CAB3XZEerHsNUr4p5rTu0msucKUnxXwFxwZVtONrkZ_czmgS+ig@mail.gmail.com>
	 <4FA19674.90804@lwfinger.net>
	 <1336390235.4325.16.camel@jlt3.sipsolutions.net>
	 <CAB3XZEfJ7vPzHnc5ACHMTnJBFGgDVFpkZ6hJ8QfXtL8L+94gOw@mail.gmail.com>
	 <CAB3XZEd7H683Gc_2Ytw7-LByOOGy5o_hRsuE3cjLhrONFc=6tg@mail.gmail.com>
	 (sfid-20120508_110047_096982_8A84E6AC)
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Sender: linux-wireless-owner@vger.kernel.org

On Tue, 2012-05-08 at 12:00 +0300, Eliad Peller wrote:
> On Tue, May 8, 2012 at 11:32 AM, Eliad Peller <eliad@wizery.com> wrote:
> > On Mon, May 7, 2012 at 2:30 PM, Johannes Berg <johannes@sipsolutions.net> wrote:
> >>> > i'm not sure this is related to the problem you're facing, but the
> >>> > commit above seems to have some bug in which a packet might get
> >>> > enqueued on invalid queue (0xff) - please try this patch (compile
> >>> > tested only):
> >>
> >> Eliad, can you submit that patch with more details?
> >>
> > sure, i'll send it soon.
> >
> i've just figured it that it doesn't seem to have any effect, as the
> hw_queue will get overridden anyway in ieee80211_tx (because
> IEEE80211_HW_QUEUE_CONTROL is not set), so i'm not sure it's really
> needed. do you want me to send it anyway?

Still seems cleaner to me, I think

johannes