Return-path: Received: from na3sys009aog119.obsmtp.com ([74.125.149.246]:47105 "EHLO na3sys009aog119.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753045Ab2E2HVh (ORCPT ); Tue, 29 May 2012 03:21:37 -0400 Received: by lagv3 with SMTP id v3so2572090lag.3 for ; Tue, 29 May 2012 00:21:34 -0700 (PDT) Message-ID: <1338276092.15008.68.camel@cumari.coelho.fi> (sfid-20120529_092154_579737_F00E8E08) Subject: Re: [PATCH] wlcore: fix undefined symbols when CONFIG_PM is not defined From: Luciano Coelho To: Eyal Shapira , "John W. Linville" Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, linux-next@vger.kernel.org, Geert Uytterhoeven Date: Tue, 29 May 2012 10:21:32 +0300 In-Reply-To: <1338275703-28103-1-git-send-email-eyal@wizery.com> References: <1338275703-28103-1-git-send-email-eyal@wizery.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, 2012-05-29 at 00:15 -0700, Eyal Shapira wrote: > commit 5063c201d7b799d6cb36d3edfc2c2c3db3b400e5 > "wl12xx: add RX filters ACX commands" breaks the build > when CONFIG_PM isn't defined: > > ERROR: "wl1271_rx_filter_get_fields_size" > [drivers/net/wireless/ti/wlcore/wlcore.ko] undefined! > ERROR: "wl1271_rx_filter_flatten_fields" > [drivers/net/wireless/ti/wlcore/wlcore.ko] undefined! > > code in drivers/net/wireless/ti/wlcore/acx.c is using these > functions unconditionally while they are #ifdefed CONFIG_PM. > Fix it by ifdefing all relevant RX filters code with CONFIG_PM. > > Reported-by: Geert Uytterhoeven > Signed-off-by: Eyal Shapira > --- Acked-by: Luciano Coelho Thanks, Eyal! John, can you push this up so it gets applied for 3.5? -- Cheers, Luca.