Return-path: Received: from fw.wantstofly.org ([80.101.37.227]:63611 "EHLO mail.wantstofly.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756601Ab2EAPtb (ORCPT ); Tue, 1 May 2012 11:49:31 -0400 Date: Tue, 1 May 2012 17:49:27 +0200 From: Lennert Buytenhek To: sedat.dilek@gmail.com Cc: "John W. Linville" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, lautriv , Jim Cromie , Ben Hutchings , Hauke Mehrtens Subject: Re: [PATCH] mwl8k: Add 0x2a02 PCI device-id (Marvell 88W8361) Message-ID: <20120501154927.GR3157@wantstofly.org> (sfid-20120501_174951_432106_B613DA4C) References: <20120427095842.GW3157@wantstofly.org> <20120427101732.GX3157@wantstofly.org> <20120427185809.GZ3157@wantstofly.org> <20120501125102.GN3157@wantstofly.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, May 01, 2012 at 03:54:49PM +0200, Sedat Dilek wrote: > Some more concerns... > Dunno, if [4] is really correct and how to use one and same device-id > for 8363 ***and*** 8361P: > ... > { PCI_VDEVICE(MARVELL, 0x2a02), .driver_data = MWL8363, }, No, you'll have to add a MWL8361P to the enum, and add a mwl8k_device_info table entry for that, and then add the PCI ID table entry with the MWL8361P identifier.