Return-path: Received: from hrndva-omtalb.mail.rr.com ([71.74.56.122]:5560 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754597Ab2EFVBI (ORCPT ); Sun, 6 May 2012 17:01:08 -0400 Date: Sun, 06 May 2012 16:01:05 -0500 From: Larry Finger To: John W Linville Cc: b43-dev@lists.infradead.org, linux-wireless@vger.kernel.org Subject: [PATCH] b43legacy: Fix error due to MMIO access with SSB unpowered Message-ID: <4fa6e691.07pJDEPTzATe9gO6%Larry.Finger@lwfinger.net> (sfid-20120506_230113_292713_49408AD2) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-wireless-owner@vger.kernel.org List-ID: There is a dummy read of a PCI MMIO register that occurs before the SSB bus has been powered, which is an error. This bug has not been seen earlier, but was apparently exposed when udev was updated to version 182. Signed-off-by: Larry Finger Cc: stable --- John, This fix should be applied to 3.4. Larry --- Index: wireless-testing-new/drivers/net/wireless/b43legacy/main.c =================================================================== --- wireless-testing-new.orig/drivers/net/wireless/b43legacy/main.c +++ wireless-testing-new/drivers/net/wireless/b43legacy/main.c @@ -1573,8 +1573,6 @@ static void b43legacy_request_firmware(s const char *filename; int err; - /* do dummy read */ - ssb_read32(dev->dev, SSB_TMSHIGH); if (!fw->ucode) { if (rev == 2) filename = "ucode2";