Return-path: Received: from mms3.broadcom.com ([216.31.210.19]:3875 "EHLO MMS3.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755500Ab2EBSxk (ORCPT ); Wed, 2 May 2012 14:53:40 -0400 Message-ID: <4FA182A8.8080604@broadcom.com> (sfid-20120502_205344_455781_14276639) Date: Wed, 2 May 2012 20:53:28 +0200 From: "Arend van Spriel" MIME-Version: 1.0 To: "John W. Linville" cc: "Kalle Valo" , "Nathan Hintz" , linux-wireless@vger.kernel.org, hauke@hauke-m.de Subject: Re: [PATCH v2 0/6] BCMA Cumulative patches from OpenWRT References: <4F990DC1.4070305@broadcom.com> <87r4vaaezl.fsf@purkki.adurom.net> <20120502181157.GC9285@tuxdriver.com> In-Reply-To: <20120502181157.GC9285@tuxdriver.com> Content-Type: text/plain; charset=iso-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 05/02/2012 08:11 PM, John W. Linville wrote: > On Thu, Apr 26, 2012 at 02:50:54PM +0300, Kalle Valo wrote: >> "Arend van Spriel" writes: >> >>> On 04/26/2012 06:23 AM, Nathan Hintz wrote: >>>> Nathan Hintz (6): >>>> bcma: Find names of non BCM cores >>>> bcma: Move initialization of SPROM to prevent overwrite >>>> bcma: Account for variable PCI memory base/size >>>> bcma: reads/writes are always 4 bytes, so always map 4 bytes >>>> bcma: Add __devexit to bcma_host_pci_remove >>>> bcma: Add flush for BCMA_RESET_CTL write >>>> >>>> arch/mips/bcm47xx/setup.c | 4 +++ >>>> arch/mips/bcm47xx/sprom.c | 2 - >>>> drivers/bcma/core.c | 1 + >>>> drivers/bcma/driver_pci_host.c | 10 +++--- >>>> drivers/bcma/host_pci.c | 4 +- >>>> drivers/bcma/scan.c | 54 +++++++++++++++++++++++++++++---------- >>>> 6 files changed, 52 insertions(+), 23 deletions(-) >>>> >>> >>> None of these patches have any description. Some motivation for the >>> changes would be appreciated like 'reported problem', 'new target >>> support', etc. >> >> I would say that it's required. Anyone can see the diff and see what was >> changed, but nobody will figure out why the change was made unless it's >> described in the commit log. So it's important to answer the question >> "Why?". > > Will we be seeing this patchset reposted with better changelogs? > > John Although not strongly stated by me I was certainly expecting a re-post. Gr. AvS