Return-path: Received: from mms2.broadcom.com ([216.31.210.18]:2360 "EHLO mms2.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751754Ab2E0Lvp (ORCPT ); Sun, 27 May 2012 07:51:45 -0400 Message-ID: <4FC2153F.4020501@broadcom.com> (sfid-20120527_135149_321442_AA41466A) Date: Sun, 27 May 2012 13:51:27 +0200 From: "Arend van Spriel" MIME-Version: 1.0 To: "Seth Forshee" cc: linux-wireless@vger.kernel.org, "Luis R. Rodriguez" Subject: Re: [RFC PATCH 3/8] brcm80211: smac: clean up channel.c References: <1334607462-5387-1-git-send-email-seth.forshee@canonical.com> <1334607462-5387-4-git-send-email-seth.forshee@canonical.com> <4FC008A1.9060005@broadcom.com> <20120526171749.GB11759@ubuntu-mba> In-Reply-To: <20120526171749.GB11759@ubuntu-mba> Content-Type: text/plain; charset=iso-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 05/26/2012 07:17 PM, Seth Forshee wrote: > On Sat, May 26, 2012 at 12:33:05AM +0200, Arend van Spriel wrote: >> We are not supporting 40MHz right now, but it is on our roadmap. I would >> prefer to keep it, but git can recover it for me when that roadmap item >> is due. > > The argument against keeping it is that it will be utterly broken by all > of the other changes. I could try to rework it along with the rest of > the code I guess, but I'd obviously be unable to test it. > > I'll keep it in if you prefer, but I should probably add a comment > warning that the code needs some attention before it can be used. Rethinking it I propose to get rid of it. 40MHz support is not complete throughout the driver so it is not worth to keep this. Gr. AvS