Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:52893 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750760Ab2FZEe1 (ORCPT ); Tue, 26 Jun 2012 00:34:27 -0400 Cc: "John W. Linville" , , Rodriguez Luis , , Rajkumar Manoharan , , , Senthil Balasubramanian , "Luis R. Rodriguez" Message-ID: <4FE93BCB.2080400@qca.qualcomm.com> (sfid-20120626_063431_636676_D103F128) Date: Tue, 26 Jun 2012 10:04:19 +0530 From: Mohammed Shafi Shajakhan MIME-Version: 1.0 To: Sujith Manoharan Subject: Re: [PATCH v3 04/10] ath9k_hw: advertise WoW support for capable chipsets References: <1340633579-7514-1-git-send-email-mohammed@qca.qualcomm.com> <1340633579-7514-5-git-send-email-mohammed@qca.qualcomm.com> <20456.40631.937743.311973@gargle.gargle.HOWL> In-Reply-To: <20456.40631.937743.311973@gargle.gargle.HOWL> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: Hi Sujith, On Monday 25 June 2012 10:54 PM, Sujith Manoharan wrote: > Mohammed Shafi Shajakhan wrote: >> From: Mohammed Shafi Shajakhan >> >> support WoW for all chipsets starting from AR9280, AR9285, AR9287, >> AR9380, AR9382, AR9485, AR9462. Really all hardware may not support >> WoW even though the flag is set and the WoW working depends on >> your laptop, BIOS apart from the hardware. >> >> Cc: Senthil Balasubramanian >> Cc: Rajkumar Manoharan >> Cc: vadivel@qca.qualcomm.com >> Signed-off-by: Luis R. Rodriguez >> Signed-off-by: Mohammed Shafi Shajakhan >> --- >> drivers/net/wireless/ath/ath9k/hw.c | 8 ++++++++ >> 1 files changed, 8 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/net/wireless/ath/ath9k/hw.c b/drivers/net/wireless/ath/ath9k/hw.c >> index a42c26f..041d797 100644 >> --- a/drivers/net/wireless/ath/ath9k/hw.c >> +++ b/drivers/net/wireless/ath/ath9k/hw.c >> @@ -2572,6 +2572,14 @@ int ath9k_hw_fill_cap_info(struct ath_hw *ah) >> } >> >> >> + if (AR_SREV_9280_20_OR_LATER(ah)) { >> + pCap->hw_caps |= ATH9K_HW_WOW_DEVICE_CAPABLE | >> + ATH9K_HW_WOW_PATTERN_MATCH_EXACT; >> + >> + if (AR_SREV_9280(ah)) >> + pCap->hw_caps |= ATH9K_HW_WOW_PATTERN_MATCH_DWORD; >> + } >> + > > I don't think this is a good idea - please enable WoW only for cards that > we have actually tested. > I had tested it in quite a few of cards like AR9280, AR9285,AR9485 with wow enabled. Further the hardware was generic, with only quite a few changes needed between AR9002 and AR9003. thank you. -- thanks, shafi