Return-path: Received: from mail-ob0-f174.google.com ([209.85.214.174]:54199 "EHLO mail-ob0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752679Ab2FKQzl (ORCPT ); Mon, 11 Jun 2012 12:55:41 -0400 Message-ID: <1339433810.4999.65.camel@lappy> (sfid-20120611_185602_173547_07FBB445) Subject: Re: net: nfc: BUG and panic in accept() on 3.5-rc2 From: Sasha Levin To: Samuel Ortiz Cc: Eric Dumazet , David Miller , lauro.venancio@openbossa.org, aloisio.almeida@openbossa.org, Dave Jones , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" , linux-wireless Date: Mon, 11 Jun 2012 18:56:50 +0200 In-Reply-To: <20120611152007.GZ22557@sortiz-mobl> References: <1339423241.4999.53.camel@lappy> <20120611144134.GX22557@sortiz-mobl> <1339425693.6001.2268.camel@edumazet-glaptop> <20120611145700.GY22557@sortiz-mobl> <1339426778.6001.2312.camel@edumazet-glaptop> <20120611152007.GZ22557@sortiz-mobl> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, 2012-06-11 at 17:20 +0200, Samuel Ortiz wrote: > On Mon, Jun 11, 2012 at 04:59:38PM +0200, Eric Dumazet wrote: > > On Mon, 2012-06-11 at 16:57 +0200, Samuel Ortiz wrote: > > > Hi Eric, > > > > > > On Mon, Jun 11, 2012 at 04:41:33PM +0200, Eric Dumazet wrote: > > > > On Mon, 2012-06-11 at 16:41 +0200, Samuel Ortiz wrote: > > > > > Hi Sasha, > > > > > > > > > > On Mon, Jun 11, 2012 at 04:00:41PM +0200, Sasha Levin wrote: > > > > > > Hi all, > > > > > > > > > > > > I've stumbled on the following while fuzzing with trinity inside a KVM tools guest, running on 3.5-rc2: > > > > > > > > > > > Thanks for the report, it could be worth adding this one to > > > > > bugzilla.kernel.org. > > > > > > > > > > What's trinity ? > > > > > Also, if this one is reproducible, would you mind sharing some details about > > > > > how we could reproduce it ? > > > > > > > > Well, bugfix should be trivial enough ;) > > > Yep, I looked at the code only after looking at Sasha's report. > > > > > > Thanks for the patch, do you mind if I add your SOB to it ? > > > > I would prefer making sure it fixes the bug first ;) > Sure, although your patch makes sense regardless of that :) > I'll still wait for Sasha to confirm that it fixes his crash. I don't have a direct way of reproducing it, but I've put it in the test vm and the fuzzer is running, I'll let you know tomorrow if it happened again.