Message-ID: <4FCDA8DB.9000000@qca.qualcomm.com> (sfid-20120605_083621_872453_927B3189)
Date: Tue, 5 Jun 2012 12:06:11 +0530
From: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
MIME-Version: 1.0
To: Johannes Berg <johannes@sipsolutions.net>
CC: "John W. Linville" <linville@tuxdriver.com>,
	<linux-wireless@vger.kernel.org>
Subject: Re: [RFC] cfg80211: Fix incompatible interfaces combination
References: <1338824836-2283-1-git-send-email-mohammed@qca.qualcomm.com>	 <1338825141.4512.14.camel@jlt3.sipsolutions.net>	 <4FCCDB63.3040806@qca.qualcomm.com>	 <1338826398.4512.23.camel@jlt3.sipsolutions.net>	 <4FCCDF78.4040606@qca.qualcomm.com>	 <1338826731.4512.24.camel@jlt3.sipsolutions.net>	 (sfid-20120604_181856_034243_5406D052) <1338826773.4512.25.camel@jlt3.sipsolutions.net>
In-Reply-To: <1338826773.4512.25.camel@jlt3.sipsolutions.net>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Sender: linux-wireless-owner@vger.kernel.org

Hi Johannes,

>
> No, initialization was incorrect -- this is better:
> http://p.sipsolutions.net/e5ab0f3e38f90d6d.txt
>

thanks a lot for the patch!
with the above patch ath9k seems be working fine with the single 
incompatible adhoc interface.
but i was just experimenting with ath9k(similar to iwlwifi having 
hw->wiphy->n_iface_combinations > 1) with this patch.

static const struct ieee80211_iface_limit a[] = {
         { .max = 2,     .types = BIT(NL80211_IFTYPE_STATION) },
};

static const struct ieee80211_iface_limit b[] = {
         { .max = 2,     .types = BIT(NL80211_IFTYPE_MESH_POINT) },
};

static const struct ieee80211_iface_combination if_comb[] = {
         {.limits = a,
         .n_limits = ARRAY_SIZE(a),
         .max_interfaces = 2,
         .num_different_channels = 1,
         },
         {.limits = b,
         .n_limits = ARRAY_SIZE(b),
         .max_interfaces = 2,
         .num_different_channels = 1,
         },

};

i could not add mesh interface if a managed interface is already there 
and vice versa. if this is the expected behavior, then fine.

dmesg
iteration 1: cfg80211_can_change_interface all_iftypes 4 and used_iftypes 84
iteration 2: cfg80211_can_change_interface all_iftypes 80 and 
used_iftypes 84


-- 
thanks,
shafi