Return-path: Received: from na3sys009aog125.obsmtp.com ([74.125.149.153]:37710 "EHLO na3sys009aog125.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756628Ab2FTPOa convert rfc822-to-8bit (ORCPT ); Wed, 20 Jun 2012 11:14:30 -0400 Received: by lbbgo11 with SMTP id go11so1040754lbb.17 for ; Wed, 20 Jun 2012 08:14:24 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1340198923.4655.64.camel@jlt3.sipsolutions.net> References: <1340173975-13609-1-git-send-email-victorg@ti.com> <1340180149.4655.23.camel@jlt3.sipsolutions.net> <1340198923.4655.64.camel@jlt3.sipsolutions.net> Date: Wed, 20 Jun 2012 18:14:24 +0300 Message-ID: (sfid-20120620_171433_735470_0C3A0E68) Subject: Re: [PATCH v4] mac80211: add command to get current rssi From: "Goldenshtein, Victor" To: Johannes Berg Cc: linux-wireless@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, Jun 20, 2012 at 4:28 PM, Johannes Berg wrote: > On Wed, 2012-06-20 at 16:22 +0300, Goldenshtein, Victor wrote: >> On Wed, Jun 20, 2012 at 11:15 AM, Johannes Berg >> wrote: >> > On Wed, 2012-06-20 at 09:32 +0300, Victor Goldenshtein wrote: >> > >> >> +     trace_drv_get_rssi(local, sdata); >> >> +     ret = local->ops->get_rssi(&local->hw, &sdata->vif, sta, rssi_dbm); >> >> +     trace_drv_return_int(local, ret); >> > >> > Where are you tracing the sta? >> > >> >> We talked about print sta address with "local_sdata_addr_evt" event >> macro, the output looks like this: >> >> #           TASK-PID   CPU#  ||||    TIMESTAMP  FUNCTION >> #              | |       |                     ||||       |         | >>               iw-1394  [000]        ...1  1083.713867: drv_get_rssi: >> phy0 vif:wlan0(2) addr:08:00:28:cc:65:43 >>               iw-1394  [000]        ...1  1083.729736: drv_return_int: phy0 - 0 > > That's not the STA address, that's the VIF address. > ops... you're right. > >> > And why not trace the value returned in *rssi_dbm? >> > >> >> Is it really required ? there are various driver-ops which are "get >> stuff" without printing them in the tracer. > > It'd be nice to fix all the ones, but I can't make you do that :-) > will respin this one two ;) -- Thanks, Victor.