Return-path: Received: from mail-gh0-f174.google.com ([209.85.160.174]:45196 "EHLO mail-gh0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755562Ab2FVLZa convert rfc822-to-8bit (ORCPT ); Fri, 22 Jun 2012 07:25:30 -0400 Received: by ghrr11 with SMTP id r11so1408395ghr.19 for ; Fri, 22 Jun 2012 04:25:29 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1340292308-6993-1-git-send-email-ozancag@gmail.com> Date: Fri, 22 Jun 2012 14:25:29 +0300 Message-ID: (sfid-20120622_132533_977129_F0B48256) Subject: Re: [PATCH v2] compat: Define include guard for vga_switcheroo.h From: =?UTF-8?B?T3phbiDDh2HEn2xheWFu?= To: "Luis R. Rodriguez" Cc: linux-wireless@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: > How about just adding this file but with something like this: > > #if (LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,34)) > /* >  * XXX: The include guard was sent upstream, drop this >  * once the guard is merged. >  */ > #ifndef LINUX_VGA_SWITCHEROO_H /* in case this gets upstream */ > #include_next > #ifndef LINUX_VGA_SWITCHEROO_H /* do not redefine once this gets upstream */ > #define LINUX_VGA_SWITCHEROO_H > #endif /* case 1 LINUX_VGA_SWITCHEROO_H > #endif /* case 2 LINUX_VGA_SWITCHEROO_H > #endif /* (LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,34)) */ Ah, that is much clever, thanks. I've tested in and it works correctly, will send a v3. But just to make clear: I'm just adding a vga_switcheroo.h with the above content and I don't touch compat-3.5.h right? -- Ozan Çağlayan