MIME-Version: 1.0
In-Reply-To: <CAD2nsn35gDLLP3Wkn9qpG5UhxUGPOcn1q_kpP2WexjQ1+LvXFg@mail.gmail.com>
References: <CALx5=V--5TEC2J39xdJn1fxLbmgEXsWwxbAVaXMsw=Lk2WxKRg@mail.gmail.com>
	<CAD2nsn04Bi5aNMBMLWGm9uQwTXzT8GnDfHZcBP8-+vMEgqBCag@mail.gmail.com>
	<CALx5=V-MEZVNkQ0SqqtLqBcDG_Dkp1V6XjiZEv4BBSVn9JQpCw@mail.gmail.com>
	<CALx5=V-L83VUcRddP=hk_vB4AK5+uZ5Gcdbg+HSbhvqNurrMbQ@mail.gmail.com>
	<CAD2nsn35gDLLP3Wkn9qpG5UhxUGPOcn1q_kpP2WexjQ1+LvXFg@mail.gmail.com>
Date: Wed, 20 Jun 2012 18:17:44 +0800
Message-ID: <CALx5=V-+aCcOMXHPrxmqVHwaiosNurT17gHBTi0mTdYJ6bZRMA@mail.gmail.com> (sfid-20120620_121802_820309_2BB33AD0)
Subject: Re: Atheros [168c 0034] can't enable wireless button LED.
From: Matt Chen <machen@suse.com>
To: Mohammed Shafi <shafi.wireless@gmail.com>
Cc: ath9k-devel@lists.ath9k.org,
	linux-wireless <linux-wireless@vger.kernel.org>
Content-Type: text/plain; charset=ISO-8859-1
Sender: linux-wireless-owner@vger.kernel.org

Hi Mohammed,

2012/6/20 Mohammed Shafi <shafi.wireless@gmail.com>:
> Hi Matt,
>
>
>>> I do
>>> 1) echo 0x402c > regidx
>>> ? ? watch -n 1 regval
>>> 2) echo 0x404c > regidx
>>> ? ?watch -n1 regval
>>>> i remember testing it in a acer laptop, it was working.
>>> Both 1) and 2) shows no different in their value no matter how I press
>>> the wifi button. :(
>
> if hardrfkill is enabled it should toggle. you are using it as ?in a
> built card right ?
> if GPIO11 is not connected to Vcc or ground it would not toggle.
> need to check it out its a regression.
>
>> I found it is not enabling the
>> wiphy_rfkill_start_polling() in gpio.c:ath_start_rfkill_poll(struct
>> ath_softc *sc).
>> The condition for (ah->caps.hw_caps & ATH9K_HW_CAP_RFSILENT) is failed.
>> Any direction I can dig further ? :)
>
> can you please try this if you can see anything
>
> diff --git a/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c
> b/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c
> index 51398f0..d732044 100644
> --- a/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c
> +++ b/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c
> @@ -3002,7 +3002,14 @@ static u32 ath9k_hw_ar9300_get_eeprom(struct ath_hw *ah,
> ? ? ? ? ?case EEP_OP_MODE:
> ? ? ? ? ? ? ? ? ?return pBase->opCapFlags.opFlags;
> ? ? ? ? ?case EEP_RF_SILENT:
> - ? ? ? ? ? ? ? return pBase->rfSilent;
> +// ? ? ? ? ? ? return pBase->rfSilent;
> + ? ? ? ? ? ? ? return 0x2f;
> + ? ? ? ? ? ? ? /* bit 0 rfkill_enable - 1
> + ? ? ? ? ? ? ? ?* bit 1 ?rfkill_polarity - 1
> + ? ? ? ? ? ? ? ?* bit 2,3,4,5 gpio pin select - 1011
> + ? ? ? ? ? ? ? ?* so 1011 11
> + ? ? ? ? ? ? ? ?* ?0x2f
> + ? ? ? ? ? ? ? ?*/
> ? ? ? ? ?case EEP_TX_MASK:
>
> please try with returning 0x2d (polarity 0 )
Both 0x2f and 0x2d can work fine to me of enabling
wiphy_rfkill_start_polling() in gpio.c:ath_start_rfkill_poll().

> think i was testing this i got
>
> "in my pci extender i always the got value of '0x6ed' for the 'reg
> 0x404c' and when i used the card as a inbuilt one i got '0xeed' and
> '0x6ed'(when i toggle rfkill in the acer laptop)."
> pls let me know if its still not working, i can check with again the
> inbuilt stuff
1) with 0x2f
   0x404c address would change when press wifi button
   rfkill block : yes -> 0x00000455
   rfkill block : no   -> 0x00000c55
2) with 0x2d
   0x404c address would change when press wifi button
   rfkill block : yes -> 0x00000455
   rfkill block : no   -> 0x00000c55


But I don't see the LED is changing, it is staying OFF (Amber).
>>>>>
>>>>> --
>>>>> Thank you.
>>>>> --
>>>>> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
>>>>> the body of a message to majordomo@vger.kernel.org
>>>>> More majordomo info at ?http://vger.kernel.org/majordomo-info.html
>>>>
>>>>
>>>>
>>>> --
>>>> thanks,
>>>> shafi
>>>>
>>>
>>>
>>>
>>> --
>>> Thank you.
>>
>>
>>
>> --
>> Thank you.
>
>
>
> --
> thanks,
> shafi
>


-- 
Thank you.