Return-path: Received: from he.sipsolutions.net ([78.46.109.217]:45671 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753997Ab2F1LSH (ORCPT ); Thu, 28 Jun 2012 07:18:07 -0400 Message-ID: <1340882283.4491.42.camel@jlt3.sipsolutions.net> (sfid-20120628_131811_900333_947AB64C) Subject: Re: [PATCH] respect channels in iface combinations From: Johannes Berg To: Michal Kazior Cc: "linux-wireless@vger.kernel.org" Date: Thu, 28 Jun 2012 13:18:03 +0200 In-Reply-To: <4FEC3BEC.2070906@tieto.com> References: <1340878025-2695-1-git-send-email-michal.kazior@tieto.com> <1340879319.4491.38.camel@jlt3.sipsolutions.net> <4FEC3BEC.2070906@tieto.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thu, 2012-06-28 at 13:11 +0200, Michal Kazior wrote: > Johannes Berg wrote: > > On Thu, 2012-06-28 at 12:06 +0200, Michal Kazior wrote: > >> Hi, > >> > >> The patchset introduces channel tracking per interface which is needed > >> to start enforcing num_different_channels in interface combinations. > >> Changes to monitor mode behaviour is also required for sane channel > >> accounting (considering how mac80211 handles monitor interfaces). > >> > >> This prepares cfg80211 for multi-channel operation. > > > > This didn't apply cleanly on mac80211-next due to preset_chan in > > net/wireless/cfg80211.h. I think it's just context, but if you developed > > this without the start_ap series I wonder how stop_ap makes much sense? > > > > I'm a bit confused now? > > This is strange. I did develop it with the start_ap patches (my base is > master-2012-06-14 on wireless-next). I may be missing a few from your > mac80211 repo though. Yeah I thought you had. I know what happened - you don't have the "pass channel" patches. Could you check & rebase? johannes