Return-path: Received: from mms2.broadcom.com ([216.31.210.18]:4966 "EHLO mms2.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753688Ab2FMN3r convert rfc822-to-8bit (ORCPT ); Wed, 13 Jun 2012 09:29:47 -0400 Message-ID: <4FD895B7.8030105@broadcom.com> (sfid-20120613_152952_655147_F8747008) Date: Wed, 13 Jun 2012 15:29:27 +0200 From: "Arend van Spriel" MIME-Version: 1.0 To: =?ISO-8859-1?Q?G=E1bor_Stefanik?= cc: "John W. Linville" , "Linux Wireless List" Subject: Re: [PATCH 5/5] brcmfmac: introduce checkdied debugfs functionality References: <1339275105-3593-1-git-send-email-arend@broadcom.com> <1339275105-3593-6-git-send-email-arend@broadcom.com> <4FD42939.2020404@broadcom.com> In-Reply-To: Content-Type: text/plain; charset=iso-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 06/10/2012 07:14 AM, G?bor Stefanik wrote: > On Sun, Jun 10, 2012 at 6:57 AM, Arend van Spriel wrote: >> On 06/10/2012 04:13 AM, G?bor Stefanik wrote: >>> On Sat, Jun 9, 2012 at 10:51 PM, Arend van Spriel wrote: >>>> >>>> +/* Device console log buffer state */ >>>> +#define CONSOLE_BUFFER_MAX 2024 >>> >>> Just out of curiosity; what is the significance of this number? >> >> It is used in the code fragment below. I have to admit the comment is >> not explaining its significance. > > But why this particular number? Did you mean 2048? > Not sure. Maybe the console info has 24 bytes overhead leaving 2024 bytes of raw buffer data, but I can only guess. Gr. AvS