Return-path: Received: from mms3.broadcom.com ([216.31.210.19]:3705 "EHLO mms3.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750922Ab2F1AmE (ORCPT ); Wed, 27 Jun 2012 20:42:04 -0400 Message-ID: <4FEBA854.5010508@broadcom.com> (sfid-20120628_024249_852213_F91CDAEE) Date: Wed, 27 Jun 2012 17:41:56 -0700 From: "Franky Lin" MIME-Version: 1.0 To: "Kevin Hilman" cc: tarun.kanti@ti.com, tony@atomide.com, santosh.shilimkar@ti.com, b-cousson@ti.com, grant.likely@secretlab.ca, linux-omap@vger.kernel.org, "linux-arm-kernel@lists.infradead.org" , "linux-wireless@vger.kernel.org" Subject: Re: Panda ES board hang when using GPIO as interrupt References: <4FE8CF77.5080400@broadcom.com> <87txxxs9we.fsf@ti.com> In-Reply-To: <87txxxs9we.fsf@ti.com> Content-Type: text/plain; charset=iso-8859-1; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 06/26/2012 08:37 PM, Kevin Hilman wrote: > "Franky Lin" writes: >> I noticed Kevin raised some similar cases on other platforms and also >> provided two patches in the patch mail thread. But unfortunately those >> two patches doesn't help in our case. I tested the driver with 3.5-rc3 >> mainline kernel and the issue is still there. I can only "fix" the >> hang by either reverting the commit or disabling >> CONFIG_PM_RUNTIME. Also, the hang only happens on Panda ES board. Old >> Panda with 4430 works good. >> >> Any thoughts and suggestions? > > If reverting the patch fixes your problem, can you isolate down to which > part of that patch causes the problem? IOW, can you fix your problem if > you undo just the hunk added in runtime_suspend or undo just the moved > hunk runtime_resume? Or is reverting both required? > > I suspect the added runtime_suspend hunk is causing the problems, so can > you see if just undoing that part works[1]. If that works, I will give > a bit more of a thinking on it tomorrow. runtime_suspend hunk is fine. The hang still exist after reverting it. The culprit is the moved hunk in runtime_resume. Reverting it makes the hang disappear. > > Thanks for reporting the problem! Bug reports like this that have > clearly been thoroughly researched and bisected are greatly appreciated! > > Kevin > You are welcome. Regards, Franky