Return-path: Received: from wolverine01.qualcomm.com ([199.106.114.254]:57456 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752166Ab2FNWQO convert rfc822-to-8bit (ORCPT ); Thu, 14 Jun 2012 18:16:14 -0400 From: "Chadd, Adrian" To: "Singh, Naveen" , "Valo, Kalle" , "Pedersen, Thomas" CC: Luciano Coelho , Johannes Berg , ath6kl-devel , "linux-wireless@vger.kernel.org" , "victorg@ti.com" Subject: RE: [PATCH] nl80211: specify RSSI threshold when scanning Date: Thu, 14 Jun 2012 22:16:13 +0000 Message-ID: <48EC4E8D43A28947B1AB2639FA97CDB90BECBD6F@nasanexd02a.na.qualcomm.com> (sfid-20120615_001618_366472_351BB6BE) References: <1339533801-32016-1-git-send-email-c_tpeder@qca.qualcomm.com> <1339566003.4519.1.camel@jlt3.sipsolutions.net> <1339587447.3840.272.camel@cumari.coelho.fi> <4FD87FEA.3070208@qca.qualcomm.com> <20120613205007.GB3043@pista> <4FD984C1.8090903@qca.qualcomm.com> <48EC4E8D43A28947B1AB2639FA97CDB90BECBC62@nasanexd02a.na.qualcomm.com> <43ED1A9ABC336248B5D371B7C9CCFB96016F339C@nasanexd02b.na.qualcomm.com> <48EC4E8D43A28947B1AB2639FA97CDB90BECBC90@nasanexd02a.na.qualcomm.com> <43ED1A9ABC336248B5D371B7C9CCFB96016F347E@nasanexd02b.na.qualcomm.com> In-Reply-To: <43ED1A9ABC336248B5D371B7C9CCFB96016F347E@nasanexd02b.na.qualcomm.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: Well, my idea was to keep the host asleep for as long as possible. So maybe only wake up the host when you have either: * filled the "scan memory" with scan results - so flush those to the host before continuing; * finished the scan, and flushing the remaining scan results out. I'm just raising the idea, it may not be worth doing.. :) Adrian -----Original Message----- From: Singh, Naveen Sent: Thursday, June 14, 2012 2:18 PM To: Chadd, Adrian; Valo, Kalle; Pedersen, Thomas Cc: Luciano Coelho; Johannes Berg; ath6kl-devel; linux-wireless@vger.kernel.org; victorg@ti.com Subject: RE: [PATCH] nl80211: specify RSSI threshold when scanning May not be possible to do in any platform you listed. I could be wrong here but from SW perspective if we decide to do following, it may be feasible: 1. We break down a single scan into multiple scan commands. Each scan just scanning one channel or a set of few channels. 2. FW at least as 4 to 6 Kbytes of memory kept for scan results. But then there will not be much time left b/w for host to go to sleep. Regards Naveen Singh -----Original Message----- From: Chadd, Adrian Sent: Thursday, June 14, 2012 1:41 PM To: Singh, Naveen; Valo, Kalle; Pedersen, Thomas Cc: Luciano Coelho; Johannes Berg; ath6kl-devel; linux-wireless@vger.kernel.org; victorg@ti.com Subject: RE: [PATCH] nl80211: specify RSSI threshold when scanning Right. What platforms would this be more doable on? Mckinley? Peregrine? Adrian -----Original Message----- From: Singh, Naveen Sent: Thursday, June 14, 2012 1:21 PM To: Chadd, Adrian; Valo, Kalle; Pedersen, Thomas Cc: Luciano Coelho; Johannes Berg; ath6kl-devel; linux-wireless@vger.kernel.org; victorg@ti.com Subject: RE: [PATCH] nl80211: specify RSSI threshold when scanning Fw memory is generally very limited. Maintaining the complete scan results is almost next to impossible. There are also other implications like taking care of duplicates, in case of similar taking the one with higher signal strength, for same AP taking care of size differences b/w probe response and beacon etc. Passing the results as you receive avoids lot of these complications. Regards Naveen -----Original Message----- From: Chadd, Adrian Sent: Thursday, June 14, 2012 12:40 PM To: Valo, Kalle; Pedersen, Thomas Cc: Luciano Coelho; Johannes Berg; ath6kl-devel; linux-wireless@vger.kernel.org; victorg@ti.com Subject: RE: [PATCH] nl80211: specify RSSI threshold when scanning Why then doesn't the host just stay asleep and let the firmware aggregate some scan results, and then fire those up in one message, waking the host up only once? Adrian -----Original Message----- From: Valo, Kalle Sent: Wednesday, June 13, 2012 11:29 PM To: Pedersen, Thomas Cc: Luciano Coelho; Johannes Berg; ath6kl-devel; linux-wireless@vger.kernel.org; victorg@ti.com Subject: Re: [PATCH] nl80211: specify RSSI threshold when scanning On 06/13/2012 11:50 PM, Pedersen, Thomas wrote: > On Wed, Jun 13, 2012 at 02:56:26PM +0300, Kalle Valo wrote: > >> Funnily enough I don't have any idea how ath6kl has implemented this >> feature, but in theory this feature is useful also for the current >> normal scan (when the firmware/hardware supports it) as we can avoid >> host wakeups. If there are 10 APs, but all are below the RSSI >> threshold, we will have only 1 host wakeup (scan ready event) opposed >> to 11 wakeups >> (10 AP found events plus 1 scan ready event). > > But can the host even sleep on normal scans? It's "implementation defined", the good ones can and bad ones can't :) But from our (wireless developer) perspective we don't need to care about that, our job is to minimise all possible host wakeup events (timers, interrupts etc) as much as possible. That will allow the host to sleep more. Kalle