Return-path: Received: from wolverine01.qualcomm.com ([199.106.114.254]:28500 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750713Ab2FZE2y (ORCPT ); Tue, 26 Jun 2012 00:28:54 -0400 Cc: "John W. Linville" , , Rodriguez Luis , , Rajkumar Manoharan , , , Senthil Balasubramanian , "Luis R. Rodriguez" Message-ID: <4FE93A7E.9050908@qca.qualcomm.com> (sfid-20120626_062858_117075_1C9AE802) Date: Tue, 26 Jun 2012 09:58:46 +0530 From: Mohammed Shafi Shajakhan MIME-Version: 1.0 To: Sujith Manoharan Subject: Re: [PATCH v3 01/10] ath9k_hw: Add register definitions for WoW support References: <1340633579-7514-1-git-send-email-mohammed@qca.qualcomm.com> <1340633579-7514-2-git-send-email-mohammed@qca.qualcomm.com> <20456.40340.61005.543469@gargle.gargle.HOWL> In-Reply-To: <20456.40340.61005.543469@gargle.gargle.HOWL> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: Hi Sujith, On Monday 25 June 2012 10:49 PM, Sujith Manoharan wrote: > Mohammed Shafi Shajakhan wrote: >> From: Mohammed Shafi Shajakhan >> >> *MAC WoW registers >> >> back-off shift, MAC interrupt enable, magic packet enable, >> pattern match enable, aifs, slot wait period, keep alive >> frame failure count, beacon fail enable, beacon timeout, >> keep alive timeout, auto keep alive disable, >> keep alive fail disable and their corresponding >> status registers. keep alive frame delay, >> pattern end/byte offsets, transmit buffers for >> keep alive frames and storing the user patterns >> >> *Power Management Control registers >> >> pme_d3cold_vaux, host_pme_enable, aux_pwr_detect, >> power_state_mask, wow_pme_clear > > The commit log could be trimmed to just say "various WoW registers". > >> +/* AR_WOW_PATTERN register values */ >> +#define AR_WOW_BACK_OFF_SHIFT(x) ((x& 0xf)<< 28) /* in usecs */ >> +#define AR_WOW_MAC_INTR_EN 0x00040000 >> +#define AR_WOW_MAGIC_EN 0x00010000 >> +#define AR_WOW_PATTERN_EN(x) (x& 0xff) >> +#define AR_WOW_PAT_FOUND_SHIFT 8 >> +#define AR_WOW_PATTERN_FOUND(x) (x& (0xff<< AR_WOW_PAT_FOUND_SHIFT)) >> +#define AR_WOW_PATTERN_FOUND_MASK ((0xff)<< AR_WOW_PAT_FOUND_SHIFT) >> +#define AR_WOW_MAGIC_PAT_FOUND 0x00020000 >> +#define AR_WOW_MAC_INTR 0x00080000 >> +#define AR_WOW_KEEP_ALIVE_FAIL 0x00100000 >> +#define AR_WOW_BEACON_FAIL 0x00200000 >> + >> +#define AR_WOW_STATUS(x) (x& (AR_WOW_PATTERN_FOUND_MASK | \ >> + AR_WOW_MAGIC_PAT_FOUND | \ >> + AR_WOW_KEEP_ALIVE_FAIL | \ >> + AR_WOW_BEACON_FAIL)) >> +#define AR_WOW_CLEAR_EVENTS(x) (x& ~(AR_WOW_PATTERN_EN(0xff) | \ >> + AR_WOW_MAGIC_EN | \ >> + AR_WOW_MAC_INTR_EN | \ >> + AR_WOW_BEACON_FAIL | \ >> + AR_WOW_KEEP_ALIVE_FAIL)) >> + > > Indentation is off in many places, please fix it. > thanks, i will check this out. -- thanks, shafi