Message-ID: <1339178163.5748.27.camel@jlt3.sipsolutions.net> (sfid-20120608_195614_138814_5C64BE11)
Subject: Re: chip id 4318 regression: WARN_ON_ONCE(sdata->vif.hw_queue[i] >=
 n_queues))
From: Johannes Berg <johannes@sipsolutions.net>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Michael =?ISO-8859-1?Q?B=FCsch?= <m@bues.ch>,
	Andre Heider <a.heider@gmail.com>,
	linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org
Date: Fri, 08 Jun 2012 19:56:03 +0200
In-Reply-To: <4FD239AA.9090708@lwfinger.net> (sfid-20120608_194312_026371_EC8C6BE2)
References: <CAHsu+b_wQOuhbBkx25CZ2cai5VVos7zK3s=EiPBy_+OnXWiWaA@mail.gmail.com>
	 <CAHsu+b9uyohfFG46R7QHht6tD3MVUzk4_LJeXp+CC2bRv=NihA@mail.gmail.com>
	 <1339167160.4901.0.camel@jlt3.sipsolutions.net>
	 <CAHsu+b-p1aTUG8L=5SCNB8Gqzwsm7_VA53Qf-ENPHmM5Z5C8hg@mail.gmail.com>
	 <1339168452.5748.0.camel@jlt3.sipsolutions.net>
	 <1339168600.5748.2.camel@jlt3.sipsolutions.net>
	 <CAHsu+b_Dp-A_kC-MSofJko3hr4dYxreYQ7rrq7wzsJXVoY_5yw@mail.gmail.com>
	 <4FD21C6B.5000402@lwfinger.net>
	 <1339170182.5748.7.camel@jlt3.sipsolutions.net>
	 <1339170287.5748.8.camel@jlt3.sipsolutions.net>
	 <1339170510.5748.9.camel@jlt3.sipsolutions.net>
	 <1339170742.5748.10.camel@jlt3.sipsolutions.net>
	 <CAHsu+b8ZGPN3iQNGH1mdzMO6kH+F1n+qZ5cT4KMcx8bh_BP1qg@mail.gmail.com>
	 <1339171159.5748.11.camel@jlt3.sipsolutions.net>
	 <CAHsu+b9EgAfq6_G8xqRzf0qHkmyQnvs7j=g4wWcSVJXstAz4mw@mail.gmail.com>
	 <4FD22727.7000500@lwfinger.net>
	 <1339172904.5748.18.camel@jlt3.sipsolutions.net>
	 <20120608183339.78a7fcbd@milhouse> <4FD239AA.9090708@lwfinger.net>
	 (sfid-20120608_194312_026371_EC8C6BE2)
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Sender: linux-wireless-owner@vger.kernel.org

On Fri, 2012-06-08 at 12:43 -0500, Larry Finger wrote:
> On 06/08/2012 11:33 AM, Michael Büsch wrote:
> >
> > Larry, did you check with PIO?
> 
> No, I only used DMA. With the latest patch, compilation is Ok, and DMA works for 
> both kinds of firmware, while PIO fails for both.

Hmm, both with QoS enabled and disabled?. I don't really see what could
be causing this, sorry.

One more thing that I just realised though is that mac80211 uses the #
of queues to determine whether to advertise QoS or not, so the whole
thing won't actually work anyway without more work :-(

I'm tempted to just remove the check for now to "fix" b43 and then maybe
you can load firmware before registering with mac80211 in b43?

johannes