Return-path: Received: from server19320154104.serverpool.info ([193.201.54.104]:48546 "EHLO hauke-m.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751275Ab2F1SOO (ORCPT ); Thu, 28 Jun 2012 14:14:14 -0400 Message-ID: <4FEC9EEF.20505@hauke-m.de> (sfid-20120628_201418_493766_BDAD0D92) Date: Thu, 28 Jun 2012 20:14:07 +0200 From: Hauke Mehrtens MIME-Version: 1.0 To: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= CC: Florian Fainelli , linville@tuxdriver.com, b43-dev@lists.infradead.org, arend@broadcom.com, linux-wireless@vger.kernel.org Subject: Re: [PATCH 6/8] bcma: handle SoCs in pmu initialization References: <1338933307-13446-1-git-send-email-hauke@hauke-m.de> <1338933307-13446-7-git-send-email-hauke@hauke-m.de> <2716026.rMfCBzMpF9@flexo> <4FD4F793.2030507@hauke-m.de> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 06/28/2012 05:52 PM, Rafał Miłecki wrote: > 2012/6/10 Hauke Mehrtens : >> On 06/10/2012 06:54 PM, Rafał Miłecki wrote: >>> 2012/6/6 Florian Fainelli : >>>> Hi Hauke, >>>> >>>> On Tuesday 05 June 2012 23:55:05 Hauke Mehrtens wrote: >>>>> The SoCs do not need any special handling in bcma_pmu_pll_init(), >>>>> bcma_pmu_resources_init(), bcma_pmu_swreg_init() and >>>>> bcma_pmu_workarounds. This patches suppresses some warnings in the log. >>>> >>>> This does not look like it scales very good, how about you turn the pr_err() >>>> into a pr_debug() so that developpers porting bcma on a new chip need to turn >>>> on the appropriate debug knobs to get the message? >>> >>> debug sounds fine for me >>> >> Hi Rafał, >> >> bcma_pmu_swreg_init() and bcma_pmu_pll_init() are doing nothing should >> they get removed? In the current version of the patch I also removed the >> chip ids of the PCIe based cards from the switch case statement if they >> just ended in a break, is that ok with you? > > Original si_pmu_pll_init had some meaning for BCM4329, BCM4319, > BCM4336 and BCM4330. I guess all of them are fullmac devices, right? > > Original si_pmu_swreg_init got meaning for BCM4336 and BCM4336. > > Seems both can be dropped? > I also check it with the BSD licensed code I have here and these functions are only containing code for fullmac chips as I see. I am for dropping them. Hauke