Return-path: Received: from mx1.redhat.com ([209.132.183.28]:54893 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751066Ab2FKSIY (ORCPT ); Mon, 11 Jun 2012 14:08:24 -0400 Date: Mon, 11 Jun 2012 13:25:45 -0400 From: Dave Jones To: Sasha Levin Cc: Samuel Ortiz , Eric Dumazet , David Miller , lauro.venancio@openbossa.org, aloisio.almeida@openbossa.org, "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" , linux-wireless Subject: Re: net: nfc: BUG and panic in accept() on 3.5-rc2 Message-ID: <20120611172545.GA1776@redhat.com> (sfid-20120611_200843_449581_B1254D70) References: <1339423241.4999.53.camel@lappy> <20120611144134.GX22557@sortiz-mobl> <1339425693.6001.2268.camel@edumazet-glaptop> <20120611145700.GY22557@sortiz-mobl> <1339426778.6001.2312.camel@edumazet-glaptop> <20120611152007.GZ22557@sortiz-mobl> <1339433810.4999.65.camel@lappy> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1339433810.4999.65.camel@lappy> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, Jun 11, 2012 at 06:56:50PM +0200, Sasha Levin wrote: > > > > > > What's trinity ? > > > > > > Also, if this one is reproducible, would you mind sharing some details about > > > > > > how we could reproduce it ? > > > > > > > > > > Well, bugfix should be trivial enough ;) > > > > Yep, I looked at the code only after looking at Sasha's report. > > > > > > > > Thanks for the patch, do you mind if I add your SOB to it ? > > > > > > I would prefer making sure it fixes the bug first ;) > > Sure, although your patch makes sense regardless of that :) > > I'll still wait for Sasha to confirm that it fixes his crash. > > I don't have a direct way of reproducing it, but I've put it in the test > vm and the fuzzer is running, I'll let you know tomorrow if it happened > again. You might be able to trigger it faster by using -P PF_NFC, which will force trinity to only use NFC sockets. sidenote: most protocols trigger the module to be auto-loaded when a socket is created. This doesn't seem to happen with nfc, making me need to manually modprobe it first. Intentional ? Dave